[CI] Create .codespellrc; upgrade codespell hook; fix typos (#12824)

Author: jbampton

.codespellrc

@@ -0,0 +1,20 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+[codespell]
+ignore-words = .github/linters/codespell.txt
+skip = systemvm/agent/noVNC/*,ui/package.json,ui/package-lock.json,ui/public/js/less.min.js,ui/public/locales/*.json,server/src/test/java/org/apache/cloudstack/network/ssl/CertServiceTest.java,test/integration/smoke/test_ssl_offloading.py

.pre-commit-config.yaml

@@ -166,13 +166,11 @@ repos:
         args: [--markdown-linebreak-ext=md]
         exclude: ^services/console-proxy/rdpconsole/src/test/doc/freerdp-debug-log\.txt$
   - repo: https://github.com/codespell-project/codespell
-    rev: v2.4.1
+    rev: v2.4.2
     hooks:
       - id: codespell
         name: run codespell
         description: Check spelling with codespell
-        args: [--ignore-words=.github/linters/codespell.txt]
-        exclude: ^systemvm/agent/noVNC/|^ui/package\.json$|^ui/package-lock\.json$|^ui/public/js/less\.min\.js$|^ui/public/locales/.*[^n].*\.json$|^server/src/test/java/org/apache/cloudstack/network/ssl/CertServiceTest.java$|^test/integration/smoke/test_ssl_offloading.py$
   - repo: https://github.com/pycqa/flake8
     rev: 7.0.0
     hooks:

framework/db/src/main/java/com/cloud/utils/db/SequenceFetcher.java

@@ -64,7 +64,7 @@ public <T> T getNextSequence(Class<T> clazz, TableGenerator tg, Object key, bool
         try {
             return future.get();
         } catch (Exception e) {
-            logger.warn("Unable to get sequeunce for " + tg.table() + ":" + tg.pkColumnValue(), e);
+            logger.warn("Unable to get sequence for " + tg.table() + ":" + tg.pkColumnValue(), e);
             return null;
         }
     }

test/integration/component/test_blocker_bugs.py

@@ -542,7 +542,7 @@ def test_01_list_routers_admin(self):
 
 
         # Validate the following
-        # 1. PreReq: have rounters that are owned by other account
+        # 1. PreReq: have routers that are owned by other account
         # 2. Create domain and create accounts in that domain
         # 3. Create one VM for each account
         # 4. Using Admin , run listRouters. It should return all the routers

ui/docs/development.md

@@ -32,7 +32,7 @@ The following tree shows the basic UI codebase filesystem:
 
 ```bash
     src
-    ├── assests       # sprites, icons, images
+    ├── assets        # sprites, icons, images
     ├── components    # Shared vue files used to render various generic / widely used components
     ├── config        # Contains the layout details of the various routes / sections available in the UI
     ├── locales       # Custom translation keys for the various supported languages

utils/src/main/java/com/cloud/utils/nio/Link.java

@@ -380,7 +380,7 @@ public static SSLEngine initServerSSLEngine(final CAService caService, final Str
         if (caService != null) {
             return caService.createSSLEngine(sslContext, clientAddress);
         }
-        LOGGER.error("CA service is not configured, by-passing CA manager to create SSL engine");
+        LOGGER.error("CA service is not configured, bypassing CA manager to create SSL engine");
         char[] passphrase = KeyStoreUtils.DEFAULT_KS_PASSPHRASE;
         final KeyStore ks = loadKeyStore(NioConnection.class.getResourceAsStream("/cloud.keystore"), passphrase);
         final KeyManagerFactory kmf = KeyManagerFactory.getInstance("SunX509");

vmware-base/src/main/java/com/cloud/hypervisor/vmware/util/VmwareHelper.java

@@ -753,7 +753,7 @@ public static String getRecommendedDiskControllerFromDescriptor(GuestOsDescripto
 
         recommendedController = guestOsDescriptor.getRecommendedDiskController();
 
-        // By-pass auto detected PVSCSI controller to use LsiLogic Parallel instead
+        // Bypass auto detected PVSCSI controller to use LsiLogic Parallel instead
         if (DiskControllerType.getType(recommendedController) == DiskControllerType.pvscsi) {
             recommendedController = DiskControllerType.lsilogic.toString();
         }