flasharray: fix delete() failing on snapshots due to invalid rename

ProviderAdapter.delete() is called for both volumes and snapshots; the
adapter treated every target as a volume and applied the same
rename-with-timestamp + destroy sequence. For snapshots this breaks
twice:

 * FlashArray snapshots live at /volume-snapshots, not /volumes, so the
   PATCH request was going to the wrong endpoint.
 * The computed rename name (<volume>.<suffix>-<timestamp>) contains
   a literal "." character, which violates the array name rules:

       Volume name must be between 1 and 63 characters (alphanumeric,
       _ and -), begin and end with a letter or number, and
       include at least one letter, _, or -.

Every CloudStack-side snapshot delete therefore failed with a 400 from
the array, leaving orphan snapshots on both sides.

Branch early when the data object is a snapshot: issue a single PATCH
to /volume-snapshots with { destroyed: true } on the original name. No
rename; the suffix the array assigns (e.g. ".1") already encodes the
ordering and we cannot safely append anything to it. The 24h recycle
bin still applies, so operators can recover a snapshot from the array
within the retention window.

Author: Eugenio Grosso

plugins/storage/volume/flasharray/src/main/java/org/apache/cloudstack/storage/datastore/adapter/flasharray/FlashArrayAdapter.java

@@ -200,9 +200,30 @@ public void detach(ProviderAdapterContext context, ProviderAdapterDataObject dat
 
     @Override
     public void delete(ProviderAdapterContext context, ProviderAdapterDataObject dataObject) {
+        String fullName = normalizeName(pod, dataObject.getExternalName());
+
+        // Snapshots live under /volume-snapshots and have the reserved form
+        // <volume>.<suffix>: the FlashArray rejects renames to any name that
+        // includes '.' or is not pure alphanumeric+'_'+'-', so we cannot
+        // tag them with a timestamp on the way out. Just mark them destroyed.
+        if (dataObject.getType() == ProviderAdapterDataObject.Type.SNAPSHOT) {
+            try {
+                FlashArrayVolume destroy = new FlashArrayVolume();
+                destroy.setDestroyed(true);
+                PATCH("/volume-snapshots?names=" + fullName, destroy, new TypeReference<FlashArrayList<FlashArrayVolume>>() {
+                });
+            } catch (CloudRuntimeException e) {
+                if (e.toString().contains("No such volume or snapshot")
+                        || e.toString().contains("Volume does not exist")) {
+                    return;
+                }
+                throw e;
+            }
+            return;
+        }
+
         // first make sure we are disconnected
         removeVlunsAll(context, pod, dataObject.getExternalName());
-        String fullName = normalizeName(pod, dataObject.getExternalName());
 
         // Rename then destroy: FlashArray keeps destroyed volumes in a recycle
         // bin (default 24h) from which they can be recovered. Renaming with a