Use prepared statement to query database for a number of VM who use a specific tag.

Author: Sina Kashipazha

engine/schema/src/main/java/com/cloud/vm/dao/VMInstanceDaoImpl.java

@@ -129,6 +129,9 @@ public class VMInstanceDaoImpl extends GenericDaoBase<VMInstanceVO, Long> implem
 
     private static final String UPDATE_SYSTEM_VM_TEMPLATE_ID_FOR_HYPERVISOR = "UPDATE `cloud`.`vm_instance` SET vm_template_id = ? WHERE type <> 'User' AND hypervisor_type = ? AND removed is NULL";
 
+    private static final String COUNT_VMS_BY_ZONE_AND_STATE_AND_HOST_TAG = "SELECT COUNT(1) FROM vm_instance vi JOIN service_offering so ON vi.service_offering_id=so.id " +
+            "JOIN vm_template vt ON vi.vm_template_id = vt.id WHERE vi.data_center_id = ? AND vi.state = ? AND vi.removed IS NULL AND (so.host_tag = ? OR vt.template_tag = ?)";
+
     @Inject
     protected HostDao _hostDao;
 
@@ -810,14 +813,15 @@ public Long countByZoneAndState(long zoneId, State state) {
     @Override
     public Long countByZoneAndStateAndHostTag(long dcId, State state, String hostTag) {
         TransactionLegacy txn = TransactionLegacy.currentTxn();
-        String sql = "SELECT COUNT(1) FROM vm_instance vi "
-                + "JOIN service_offering so ON vi.service_offering_id=so.id "
-                + "JOIN vm_template vt ON vi.vm_template_id = vt.id "
-                + "WHERE vi.data_center_id= " + dcId + " AND vi.state = '" + state + "' AND vi.removed IS NULL "
-                + "AND (so.host_tag='" + hostTag + "' OR vt.template_tag='" + hostTag + "')";
         PreparedStatement pstmt = null;
         try {
-            pstmt = txn.prepareAutoCloseStatement(sql);
+            pstmt = txn.prepareAutoCloseStatement(COUNT_VMS_BY_ZONE_AND_STATE_AND_HOST_TAG);
+
+            pstmt.setLong(1, dcId);
+            pstmt.setString(2, String.valueOf(state));
+            pstmt.setString(3, hostTag);
+            pstmt.setString(4, hostTag);
+
             ResultSet rs = pstmt.executeQuery();
             if (rs.next()) {
                 return rs.getLong(1);

systemvm/debian/root/version

@@ -0,0 +1 @@
+prometheus-exporter-enhancement-20211213T174523