flasharray: fix delete() rejecting volumes with {name, destroyed} PATCH

FlashArrayAdapter.delete() builds one FlashArrayVolume, then issues two
PATCH requests on it: first to rename the volume with a timestamp suffix
so a recreated volume with the same name would not collide with the
destroyed copy in FlashArrays 24h recycle bin, then to mark it
destroyed. The second PATCH reuses the same object, which still has the
new name set, so the request body carries both name and destroyed.

Purity 6.x rejects that combination with

    400 Bad Request
    Invalid combination of parameters specified.

and every CloudStack-side volume delete ends with the volume renamed
(first PATCH succeeded) but not destroyed (second PATCH rejected). That
leaves the volume leaking on the array and the CloudStack volume row
stuck in Destroy state with no clean way forward via the UI.

Rename and destroy are still issued, but as two separate PATCHes each
carrying only its own field, preserving the forensic value of the
timestamp suffix while working around the API restriction.

Author: Eugenio Grosso

plugins/storage/volume/flasharray/src/main/java/org/apache/cloudstack/storage/datastore/adapter/flasharray/FlashArrayAdapter.java

@@ -204,21 +204,25 @@ public void delete(ProviderAdapterContext context, ProviderAdapterDataObject dat
         removeVlunsAll(context, pod, dataObject.getExternalName());
         String fullName = normalizeName(pod, dataObject.getExternalName());
 
-        FlashArrayVolume volume = new FlashArrayVolume();
-
-        // rename as we delete so it doesn't conflict if the template or volume is ever recreated
-        // pure keeps the volume(s) around in a Destroyed bucket for a period of time post delete
+        // Rename then destroy: FlashArray keeps destroyed volumes in a recycle
+        // bin (default 24h) from which they can be recovered. Renaming with a
+        // deletion timestamp gives operators a forensic trail when browsing the
+        // array - they can see when each destroyed copy was deleted on the
+        // CloudStack side. FlashArray rejects a single PATCH that combines
+        // {name, destroyed}, so the rename and the destroy must be issued as
+        // two separate requests each carrying only its own field.
         String timestamp = new SimpleDateFormat("yyyyMMddHHmmss").format(new java.util.Date());
-        volume.setExternalName(fullName + "-" + timestamp);
+        String renamedName = fullName + "-" + timestamp;
 
         try {
-            PATCH("/volumes?names=" + fullName, volume, new TypeReference<FlashArrayList<FlashArrayVolume>>() {
+            FlashArrayVolume rename = new FlashArrayVolume();
+            rename.setExternalName(renamedName);
+            PATCH("/volumes?names=" + fullName, rename, new TypeReference<FlashArrayList<FlashArrayVolume>>() {
             });
 
-            // now delete it with new name
-            volume.setDestroyed(true);
-
-            PATCH("/volumes?names=" + fullName + "-" + timestamp, volume, new TypeReference<FlashArrayList<FlashArrayVolume>>() {
+            FlashArrayVolume destroy = new FlashArrayVolume();
+            destroy.setDestroyed(true);
+            PATCH("/volumes?names=" + renamedName, destroy, new TypeReference<FlashArrayList<FlashArrayVolume>>() {
             });
         } catch (CloudRuntimeException e) {
             if (e.toString().contains("Volume does not exist")) {