Skip to content

Commit 699a54a

Browse files
committed
update 3: remove new validation to keep backwards compatibility
1 parent c4a57f9 commit 699a54a

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

server/src/main/java/com/cloud/network/vpc/NetworkACLServiceImpl.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,6 @@
7272
import com.cloud.utils.db.SearchCriteria.Op;
7373
import com.cloud.utils.exception.CloudRuntimeException;
7474
import com.cloud.utils.net.NetUtils;
75-
import com.cloud.utils.net.NetworkProtocols;
7675

7776
@Component
7877
public class NetworkACLServiceImpl extends ManagerBase implements NetworkACLService {
@@ -588,11 +587,6 @@ protected void validateProtocol(NetworkACLItemVO networkACLItemVO) {
588587
if (!isIcmpProtocol && (icmpCode != null || icmpType != null)) {
589588
throw new InvalidParameterValueException("Can specify icmpCode and icmpType for ICMP protocol only");
590589
}
591-
if (isIcmpProtocol) {
592-
if (!NetworkProtocols.validateIcmpTypeAndCode(icmpType, icmpCode)) {
593-
throw new InvalidParameterValueException(String.format("Unsupported icmptype %s or icmpcode %s", icmpType, icmpCode));
594-
}
595-
}
596590

597591
Integer sourcePortStart = networkACLItemVO.getSourcePortStart();
598592
Integer sourcePortEnd = networkACLItemVO.getSourcePortEnd();

0 commit comments

Comments
 (0)