add InternalBackupServiceImplTest

Author: JoaoJandre

server/src/main/java/org/apache/cloudstack/backup/InternalBackupServiceImpl.java

@@ -159,7 +159,7 @@ public void cleanupBackupMetadata(long volumeId) {
 
     @Override
     public void prepareVolumeForDetach(Volume volume, VirtualMachine virtualMachine) {
-        if (!backupManager.BackupFrameworkEnabled.valueIn(virtualMachine.getDataCenterId())) {
+        if (isBackupFrameworkDisabled(virtualMachine)) {
             return;
         }
 
@@ -176,7 +176,7 @@ public void prepareVolumeForMigration(Volume volume) {
             return;
         }
         VirtualMachine virtualMachine = virtualMachineManager.findById(volume.getInstanceId());
-        if (!backupManager.BackupFrameworkEnabled.valueIn(virtualMachine.getDataCenterId())) {
+        if (isBackupFrameworkDisabled(virtualMachine)) {
             return;
         }
         InternalBackupProvider internalBackupProvider = getInternalBackupProviderForZone(volume.getDataCenterId());
@@ -193,7 +193,7 @@ public void updateVolumeId(long oldVolumeId, long newVolumeId) {
             return;
         }
         VirtualMachine virtualMachine = virtualMachineManager.findById(volumeVO.getInstanceId());
-        if (!backupManager.BackupFrameworkEnabled.valueIn(virtualMachine.getDataCenterId())) {
+        if (isBackupFrameworkDisabled(virtualMachine)) {
             return;
         }
 
@@ -207,7 +207,7 @@ public void updateVolumeId(long oldVolumeId, long newVolumeId) {
     @Override
     public void prepareVmForSnapshotRevert(VMSnapshot vmSnapshot) {
         VirtualMachine virtualMachine = virtualMachineManager.findById(vmSnapshot.getVmId());
-        if (!backupManager.BackupFrameworkEnabled.valueIn(virtualMachine.getDataCenterId())) {
+        if (isBackupFrameworkDisabled(virtualMachine)) {
             return;
         }
 
@@ -350,4 +350,8 @@ protected InternalBackupProvider getInternalBackupProviderForZone(long zoneId) {
             return internalBackupProviderMap.get(backupProvider.getName());
         });
     }
+
+    protected boolean isBackupFrameworkDisabled(VirtualMachine virtualMachine) {
+        return !BackupManager.BackupFrameworkEnabled.valueIn(virtualMachine.getDataCenterId());
+    }
 }