AutoScaling: use DbUpgradeUtils.addForeignKey instead of SQL procedure

Author: weizhouapache

engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41800to41810.java

@@ -58,6 +58,7 @@ public InputStream[] getPrepareScripts() {
     @Override
     public void performDataMigration(Connection conn) {
         fixForeignKeyNames(conn);
+        addForeignKeyToAutoscaleVmprofiles(conn);
     }
 
     @Override
@@ -111,4 +112,8 @@ private void fixForeignKeyNames(Connection conn) {
         DbUpgradeUtils.dropKeysIfExist(conn, "cloud.volumes", keys, false);
         DbUpgradeUtils.addForeignKey(conn, "volumes", "passphrase_id","passphrase", "id");
     }
+
+    private void addForeignKeyToAutoscaleVmprofiles(Connection conn) {
+        DbUpgradeUtils.addForeignKey(conn, "autoscale_vmprofiles", "user_data_id","user_data", "id");
+    }
 }

engine/schema/src/main/resources/META-INF/db/schema-41800to41810.sql

@@ -34,5 +34,4 @@ CALL ADD_GUEST_OS_AND_HYPERVISOR_MAPPING (6, 'Windows Server 2022 (64-bit)', 'Xe
 
 -- Support userdata ids and details in VM AutoScaling
 CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.autoscale_vmprofiles', 'user_data_id', 'bigint unsigned DEFAULT NULL COMMENT "id of the user data" AFTER `user_data`');
-CALL `cloud`.`IDEMPOTENT_ADD_FOREIGN_KEY`('cloud.autoscale_vmprofiles', 'user_data', 'id');
 CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.autoscale_vmprofiles', 'user_data_details', 'mediumtext DEFAULT NULL COMMENT "value of the comma-separated list of parameters" AFTER `user_data_id`');