Skip to content

Commit 8fd6b8f

Browse files
committed
Fix bean injection
1 parent 49bc5e8 commit 8fd6b8f

File tree

2 files changed

+7
-9
lines changed

2 files changed

+7
-9
lines changed

server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,6 @@
123123
import com.cloud.utils.LogUtils;
124124
import com.cloud.utils.Pair;
125125
import com.cloud.utils.UuidUtils;
126-
import com.cloud.utils.component.ComponentContext;
127126
import com.cloud.utils.db.EntityManager;
128127
import com.cloud.utils.exception.CloudRuntimeException;
129128
import com.cloud.utils.net.NetUtils;
@@ -316,10 +315,10 @@ public class UnmanagedVMsManagerImpl implements UnmanagedVMsManager {
316315
@Inject
317316
private ImportVmTasksManager importVmTasksManager;
318317

319-
private KubernetesServiceHelper kubernetesServiceHelper;
318+
private List<KubernetesServiceHelper> kubernetesServiceHelpers;
320319

321-
private void setKubernetesServiceHelper(KubernetesServiceHelper helper) {
322-
this.kubernetesServiceHelper = helper;
320+
public void setKubernetesServiceHelpers(final List<KubernetesServiceHelper> kubernetesServiceHelpers) {
321+
this.kubernetesServiceHelpers = kubernetesServiceHelpers;
323322
}
324323

325324
protected Gson gson;
@@ -2394,10 +2393,7 @@ void performUnmanageVMInstancePrechecks(VMInstanceVO vmVO) {
23942393
}
23952394

23962395
private boolean isVmPartOfCKSCluster(VMInstanceVO vmVO) {
2397-
if (kubernetesServiceHelper == null) {
2398-
setKubernetesServiceHelper(ComponentContext.getComponent(KubernetesServiceHelper.class));
2399-
}
2400-
return kubernetesServiceHelper.findByVmId(vmVO.getId()) != null;
2396+
return kubernetesServiceHelpers.get(0).findByVmId(vmVO.getId()) != null;
24012397
}
24022398

24032399
private boolean hasVolumeSnapshotsPriorToUnmanageVM(VMInstanceVO vmVO) {

server/src/main/resources/META-INF/cloudstack/server-compute/spring-server-compute-context.xml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,9 @@
3535
<property name="name" value="LXCGuru" />
3636
</bean>
3737

38-
<bean id="vmImportService" class="org.apache.cloudstack.vm.UnmanagedVMsManagerImpl" />
38+
<bean id="vmImportService" class="org.apache.cloudstack.vm.UnmanagedVMsManagerImpl">
39+
<property name="kubernetesServiceHelpers" value="#{kubernetesServiceHelperRegistry.registered}" />
40+
</bean>
3941

4042
<bean id="importVmTasksManager" class="org.apache.cloudstack.vm.ImportVmTasksManagerImpl" />
4143

0 commit comments

Comments
 (0)