handle when share context is disabled

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

Author: shwstppr

framework/extensions/src/main/java/org/apache/cloudstack/framework/extensions/manager/ExtensionsShareManagerImpl.java

@@ -62,6 +62,7 @@
 import com.cloud.utils.component.ManagerBase;
 import com.cloud.utils.concurrency.NamedThreadFactory;
 import com.cloud.utils.db.GlobalLock;
+import com.cloud.utils.exception.CloudRuntimeException;
 
 public class ExtensionsShareManagerImpl extends ManagerBase implements ExtensionsShareManager {
 
@@ -82,6 +83,7 @@ public class ExtensionsShareManagerImpl extends ManagerBase implements Extension
 
     private ScheduledExecutorService extensionShareCleanupExecutor;
     private int shareLinkValidityInterval;
+    private boolean serverShareEnabled = true;
 
     protected Path getExtensionsSharePath() {
         String shareBaseDir = ServerPropertiesUtil.getShareBaseDirectory();
@@ -213,7 +215,10 @@ protected ArchiveInfo createArchiveForDownload(Extension extension) throws IOExc
       * @throws InvalidKeyException if the secret key is invalid
       */
     protected String generateSignedArchiveUrl(ManagementServerHost managementServer, Path archivePath)
-            throws DecoderException, NoSuchAlgorithmException, InvalidKeyException {
+            throws DecoderException, NoSuchAlgorithmException, InvalidKeyException, CloudRuntimeException {
+        if (!serverShareEnabled) {
+            throw new CloudRuntimeException("Share context is disabled on this management server in server.properties");
+        }
         final String baseUrl = getManagementServerBaseUrl(managementServer);
         final long expiresAtEpochSec = System.currentTimeMillis() / 1000L + shareLinkValidityInterval;
         final String secretKey = ServerPropertiesUtil.getShareSecret();
@@ -442,6 +447,7 @@ public boolean start() {
                 initialDelay, shareLinkValidityInterval);
         extensionShareCleanupExecutor.scheduleWithFixedDelay(new ShareCleanupWorker(),
                 initialDelay, shareLinkValidityInterval, TimeUnit.SECONDS);
+        serverShareEnabled = ServerPropertiesUtil.getShareEnabled();
         return true;
     }
 
@@ -468,7 +474,7 @@ public Pair<Boolean, String> syncExtension(Extension extension, ManagementServer
             String signedUrl;
             try {
                 signedUrl = generateSignedArchiveUrl(sourceManagementServer, archiveInfo.getPath());
-            } catch (DecoderException | NoSuchAlgorithmException | InvalidKeyException e) {
+            } catch (DecoderException | NoSuchAlgorithmException | InvalidKeyException | CloudRuntimeException e) {
                 String msg = "Failed to generate signed URL";
                 logger.error("{} for {} using {}", msg, extension, sourceManagementServer, e);
                 return new Pair<>(false, msg);

framework/extensions/src/test/java/org/apache/cloudstack/framework/extensions/manager/ExtensionsShareManagerImplTest.java

@@ -59,13 +59,15 @@
 import org.mockito.Mockito;
 import org.mockito.Spy;
 import org.mockito.junit.MockitoJUnitRunner;
+import org.springframework.test.util.ReflectionTestUtils;
 
 import com.cloud.agent.api.Answer;
 import com.cloud.cluster.ClusterManager;
 import com.cloud.serializer.GsonHelper;
 import com.cloud.utils.FileUtil;
 import com.cloud.utils.HttpUtils;
 import com.cloud.utils.Pair;
+import com.cloud.utils.exception.CloudRuntimeException;
 
 @RunWith(MockitoJUnitRunner.class)
 public class ExtensionsShareManagerImplTest {
@@ -360,6 +362,13 @@ public void createArchiveForDownloadThrowsExceptionWhenPackingFails() throws IOE
         assertTrue(exception.getMessage().contains("Failed to create archive"));
     }
 
+    @Test(expected = CloudRuntimeException.class)
+    public void generateSignedArchiveUrlThrowsExceptionONSHareContextDisabled() throws Exception {
+        ReflectionTestUtils.setField(extensionsShareManager, "serverShareEnabled", false);
+        extensionsShareManager.generateSignedArchiveUrl(mock(ManagementServerHost.class),
+                Path.of("/share/extensions/test-archive.tgz"));
+    }
+
     @Test
     public void generateSignedArchiveUrlReturnsValidUrlWithSignature() throws Exception {
         ManagementServerHost managementServer = mock(ManagementServerHost.class);