Fix VNC SecurityType None on RFB v3.8 (#7287)

Author: nvazquez

services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyNoVncClient.java

@@ -200,7 +200,7 @@ protected void handshakeSecurityResult(int secType) {
         client.processHandshakeSecurityType(secType, getClientHostPassword(),
                 getClientHostAddress(), getClientHostPort());
 
-        client.processSecurityResultMsg(secType);
+        client.processSecurityResultMsg();
         byte[] securityResultToClient = new byte[] { 0, 0, 0, 0 };
         sendMessageToVNCClient(securityResultToClient, 4);
         client.setWaitForNoVnc(true);

services/console-proxy/server/src/main/java/com/cloud/consoleproxy/vnc/NoVncClient.java

@@ -472,18 +472,13 @@ private Pair<Boolean, String> processSecurityResultType(int authResult) {
         return new Pair<>(result, message);
     }
 
-    public void processSecurityResultMsg(int securityType) {
+    public void processSecurityResultMsg() {
         if (s_logger.isDebugEnabled()) {
             s_logger.debug("Processing security result message");
         }
 
-        int result;
-        if (securityType == RfbConstants.NO_AUTH) {
-            result = RfbConstants.VNC_AUTH_OK;
-        } else {
-            nioSocketConnection.waitForBytesAvailableForReading(1);
-            result = nioSocketConnection.readUnsignedInteger(32);
-        }
+        nioSocketConnection.waitForBytesAvailableForReading(1);
+        int result = nioSocketConnection.readUnsignedInteger(32);
 
         Pair<Boolean, String> securityResultType = processSecurityResultType(result);
         boolean success = BooleanUtils.toBoolean(securityResultType.first());