Skip to content

Commit be89e6f

Browse files
[KVM] Reorder migration logs to prevent populating agent logs on migrations (#12883)
* Move logs for values of the migration settings out of the loop * Apply suggestions from code review Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com> --------- Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>
1 parent 6c1437b commit be89e6f

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -259,6 +259,12 @@ Use VIR_DOMAIN_XML_SECURE (value = 1) prior to v1.0.0.
259259
final int migrateDowntime = libvirtComputingResource.getMigrateDowntime();
260260
boolean isMigrateDowntimeSet = false;
261261

262+
final int migrateWait = libvirtComputingResource.getMigrateWait();
263+
logger.info("vm.migrate.wait value set to: {} secs for VM: {}", migrateWait, vmName);
264+
265+
final int migratePauseAfter = libvirtComputingResource.getMigratePauseAfter();
266+
logger.info("vm.migrate.pauseafter value set to: {} ms for VM: {}", migratePauseAfter, vmName);
267+
262268
while (!executor.isTerminated()) {
263269
Thread.sleep(100);
264270
sleeptime += 100;
@@ -278,8 +284,6 @@ Use VIR_DOMAIN_XML_SECURE (value = 1) prior to v1.0.0.
278284
}
279285

280286
// abort the vm migration if the job is executed more than vm.migrate.wait
281-
final int migrateWait = libvirtComputingResource.getMigrateWait();
282-
logger.info("vm.migrate.wait value set to: {}for VM: {}", migrateWait, vmName);
283287
if (migrateWait > 0 && sleeptime > migrateWait * 1000) {
284288
DomainState state = null;
285289
try {
@@ -306,8 +310,6 @@ Use VIR_DOMAIN_XML_SECURE (value = 1) prior to v1.0.0.
306310
}
307311

308312
// pause vm if we meet the vm.migrate.pauseafter threshold and not already paused
309-
final int migratePauseAfter = libvirtComputingResource.getMigratePauseAfter();
310-
logger.info("vm.migrate.pauseafter value set to: {} for VM: {}", migratePauseAfter, vmName);
311313
if (migratePauseAfter > 0 && sleeptime > migratePauseAfter) {
312314
DomainState state = null;
313315
try {

0 commit comments

Comments
 (0)