Skip to content

Commit c0ddda3

Browse files
authored
[VMware] Fix service offerings listing on appliances deployment options (#5752)
* Fix list service offerings for VMware deployment options * UI fix to allow selecting offerings
1 parent dcdcd09 commit c0ddda3

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

server/src/main/java/com/cloud/api/query/QueryManagerImpl.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3135,6 +3135,7 @@ private Pair<List<ServiceOfferingJoinVO>, Integer> searchForServiceOfferingsInte
31353135
SearchCriteria<ServiceOfferingJoinVO> cpuSearchCriteria = _srvOfferingJoinDao.createSearchCriteria();
31363136
cpuSearchCriteria.addOr("minCpu", Op.NULL);
31373137
cpuSearchCriteria.addOr("constraints", Op.SC, cpuConstraintSearchCriteria);
3138+
cpuSearchCriteria.addOr("minCpu", Op.GTEQ, cpuNumber);
31383139

31393140
sc.addAnd("cpuConstraints", SearchCriteria.Op.SC, cpuSearchCriteria);
31403141
}
@@ -3147,14 +3148,15 @@ private Pair<List<ServiceOfferingJoinVO>, Integer> searchForServiceOfferingsInte
31473148
SearchCriteria<ServiceOfferingJoinVO> memSearchCriteria = _srvOfferingJoinDao.createSearchCriteria();
31483149
memSearchCriteria.addOr("minMemory", Op.NULL);
31493150
memSearchCriteria.addOr("memconstraints", Op.SC, memoryConstraintSearchCriteria);
3151+
memSearchCriteria.addOr("minMemory", Op.GTEQ, memory);
31503152

31513153
sc.addAnd("memoryConstraints", SearchCriteria.Op.SC, memSearchCriteria);
31523154
}
31533155

31543156
if (cpuSpeed != null) {
31553157
SearchCriteria<ServiceOfferingJoinVO> cpuSpeedSearchCriteria = _srvOfferingJoinDao.createSearchCriteria();
31563158
cpuSpeedSearchCriteria.addOr("speed", Op.NULL);
3157-
cpuSpeedSearchCriteria.addOr("speed", Op.EQ, cpuSpeed);
3159+
cpuSpeedSearchCriteria.addOr("speed", Op.GTEQ, cpuSpeed);
31583160
sc.addAnd("cpuspeedconstraints", SearchCriteria.Op.SC, cpuSpeedSearchCriteria);
31593161
}
31603162

ui/src/views/compute/wizard/ComputeOfferingSelection.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -157,11 +157,11 @@ export default {
157157
(item.iscustomized === true && maxCpuNumber < this.minimumCpunumber))) {
158158
disabled = true
159159
}
160-
if (disabled === false && this.minimumCpuspeed > 0 && maxCpuSpeed && maxCpuSpeed !== this.minimumCpuspeed) {
160+
if (disabled === false && this.minimumCpuspeed > 0 && maxCpuSpeed && maxCpuSpeed < this.minimumCpuspeed) {
161161
disabled = true
162162
}
163163
if (disabled === false && maxMemory && this.minimumMemory > 0 &&
164-
((item.iscustomized === false && maxMemory !== this.minimumMemory) ||
164+
((item.iscustomized === false && maxMemory < this.minimumMemory) ||
165165
(item.iscustomized === true && maxMemory < this.minimumMemory))) {
166166
disabled = true
167167
}

0 commit comments

Comments
 (0)