address comments

Author: vishesh92

server/src/main/java/com/cloud/api/query/dao/AccountJoinDaoImpl.java

@@ -221,13 +221,7 @@ public void setResourceLimits(AccountJoinVO account, boolean fullView, ResourceL
         response.setMemoryAvailable(memoryAvail);
 
         //get resource limits for gpus
-        long gpuLimit = ApiDBUtils.findCorrectResourceLimit(account.getGpuLimit(), account.getId(), ResourceType.gpu);
-        String gpuLimitDisplay = (fullView || gpuLimit == -1) ? Resource.UNLIMITED : String.valueOf(gpuLimit);
-        long gpuTotal = (account.getGpuTotal() == null) ? 0 : account.getGpuTotal();
-        String gpuAvail = (fullView || gpuLimit == -1) ? Resource.UNLIMITED : String.valueOf(gpuLimit - gpuTotal);
-        response.setGpuLimit(gpuLimitDisplay);
-        response.setGpuTotal(gpuTotal);
-        response.setGpuAvailable(gpuAvail);
+        setGpuResourceLimits(account, fullView,response);
 
         //get resource limits for primary storage space and convert it from Bytes to GiB
         long primaryStorageLimit = ApiDBUtils.findCorrectResourceLimit(account.getPrimaryStorageLimit(), account.getId(), ResourceType.primary_storage);
@@ -287,6 +281,16 @@ public void setResourceLimits(AccountJoinVO account, boolean fullView, ResourceL
         response.setObjectStorageAvailable(objectStorageAvail);
     }
 
+    private void setGpuResourceLimits(AccountJoinVO account, boolean fullView, ResourceLimitAndCountResponse response) {
+        long gpuLimit = ApiDBUtils.findCorrectResourceLimit(account.getGpuLimit(), account.getId(), ResourceType.gpu);
+        String gpuLimitDisplay = (fullView || gpuLimit == -1) ? Resource.UNLIMITED : String.valueOf(gpuLimit);
+        long gpuTotal = (account.getGpuTotal() == null) ? 0 : account.getGpuTotal();
+        String gpuAvail = (fullView || gpuLimit == -1) ? Resource.UNLIMITED : String.valueOf(gpuLimit - gpuTotal);
+        response.setGpuLimit(gpuLimitDisplay);
+        response.setGpuTotal(gpuTotal);
+        response.setGpuAvailable(gpuAvail);
+    }
+
     @Override
     public List<AccountJoinVO> searchByIds(Long... accountIds) {
         // set detail batch query size

server/src/main/java/com/cloud/api/query/dao/DomainJoinDaoImpl.java

@@ -196,13 +196,7 @@ public void setResourceLimits(DomainJoinVO domain, boolean fullView, ResourceLim
         response.setMemoryAvailable(memoryAvail);
 
         //get resource limits for gpus
-        long gpuLimit = ApiDBUtils.findCorrectResourceLimitForDomain(domain.getGpuLimit(), ResourceType.gpu, domain.getId());
-        String gpuLimitDisplay = (fullView || gpuLimit == -1) ? Resource.UNLIMITED : String.valueOf(gpuLimit);
-        long gpuTotal = (domain.getGpuTotal() == null) ? 0 : domain.getGpuTotal();
-        String gpuAvail = (fullView || gpuLimit == -1) ? Resource.UNLIMITED : String.valueOf(gpuLimit - gpuTotal);
-        response.setGpuLimit(gpuLimitDisplay);
-        response.setGpuTotal(gpuTotal);
-        response.setGpuAvailable(gpuAvail);
+        setGpuResourceLimits(domain, fullView, response);
 
       //get resource limits for primary storage space and convert it from Bytes to GiB
         long primaryStorageLimit = ApiDBUtils.findCorrectResourceLimitForDomain(domain.getPrimaryStorageLimit(), ResourceType.primary_storage, domain.getId());
@@ -259,6 +253,16 @@ public void setResourceLimits(DomainJoinVO domain, boolean fullView, ResourceLim
         response.setObjectStorageAvailable(objectStorageAvail);
     }
 
+    private void setGpuResourceLimits(DomainJoinVO domain, boolean fullView, ResourceLimitAndCountResponse response) {
+        long gpuLimit = ApiDBUtils.findCorrectResourceLimitForDomain(domain.getGpuLimit(), ResourceType.gpu, domain.getId());
+        String gpuLimitDisplay = (fullView || gpuLimit == -1) ? Resource.UNLIMITED : String.valueOf(gpuLimit);
+        long gpuTotal = (domain.getGpuTotal() == null) ? 0 : domain.getGpuTotal();
+        String gpuAvail = (fullView || gpuLimit == -1) ? Resource.UNLIMITED : String.valueOf(gpuLimit - gpuTotal);
+        response.setGpuLimit(gpuLimitDisplay);
+        response.setGpuTotal(gpuTotal);
+        response.setGpuAvailable(gpuAvail);
+    }
+
     @Override
     public List<DomainJoinVO> searchByIds(Long... domainIds) {
         // set detail batch query size

server/src/main/java/com/cloud/server/ManagementServerImpl.java

@@ -1549,13 +1549,7 @@ public Ternary<Pair<List<? extends Host>, Integer>, List<? extends Host>, Map<Ho
             throw new InvalidParameterValueException("Unsupported operation, VM uses Local storage, cannot migrate");
         }
 
-        ServiceOffering serviceOffering = vmProfile.getServiceOffering();
-        if (serviceOffering.getVgpuProfileId() != null) {
-            VgpuProfileVO vgpuProfile = vgpuProfileDao.findById(serviceOffering.getVgpuProfileId());
-            if (vgpuProfile == null || "passthrough".equals(vgpuProfile.getName())) {
-                throw new InvalidParameterValueException("Unsupported operation, VM uses host passthrough, cannot migrate");
-            }
-        }
+        validateVgpuProfileForVmMigration(vmProfile);
 
         final Type hostType = srcHost.getType();
         Pair<List<HostVO>, Integer> allHostsPair = null;
@@ -1683,6 +1677,17 @@ public Ternary<Pair<List<? extends Host>, Integer>, List<? extends Host>, Map<Ho
         return new Ternary<>(otherHosts, suitableHosts, requiresStorageMotion);
     }
 
+    private void validateVgpuProfileForVmMigration(final VirtualMachineProfile vmProfile) {
+        // Validate if the VM is using a vGPU profile that supports migration.
+        ServiceOffering serviceOffering = vmProfile.getServiceOffering();
+        if (serviceOffering.getVgpuProfileId() != null) {
+            VgpuProfileVO vgpuProfile = vgpuProfileDao.findById(serviceOffering.getVgpuProfileId());
+            if (vgpuProfile == null || "passthrough".equals(vgpuProfile.getName())) {
+                throw new InvalidParameterValueException("Unsupported operation, VM uses host passthrough, cannot migrate");
+            }
+        }
+    }
+
     /**
      * Add non DPDK enabled hosts to the avoid list
      */