Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Fabricio Duarte <fabricio.duarte.jr@gmail.com>

Author: 3 people

framework/quota/src/main/java/org/apache/cloudstack/quota/activationrule/presetvariables/PresetVariableHelper.java

@@ -814,7 +814,7 @@ protected void loadPresetVariableValueForVpc(UsageVO usageRecord, Value value) {
         value.setVpcOffering(getPresetVariableValueVpcOffering(vpc.getVpcOfferingId()));
     }
 
-    protected GenericPresetVariable getPresetVariableValueVpcOffering(long vpcOfferingId) {
+    protected GenericPresetVariable getPresetVariableValueVpcOffering(Long vpcOfferingId) {
         VpcOfferingVO vpcOfferingVo = vpcOfferingDao.findByIdIncludingRemoved(vpcOfferingId);
         validateIfObjectIsNull(vpcOfferingVo, vpcOfferingId, "vpc offering");
 

framework/quota/src/main/java/org/apache/cloudstack/quota/activationrule/presetvariables/Value.java

@@ -268,7 +268,6 @@ public GenericPresetVariable getNetworkOffering() {
 
     public void setNetworkOffering(GenericPresetVariable networkOffering) {
         this.networkOffering = networkOffering;
-        fieldNamesToIncludeInToString.add("networkOffering");
     }
 
     public GenericPresetVariable getVpcOffering() {
@@ -277,6 +276,5 @@ public GenericPresetVariable getVpcOffering() {
 
     public void setVpcOffering(GenericPresetVariable vpcOffering) {
         this.vpcOffering = vpcOffering;
-        fieldNamesToIncludeInToString.add("vpcOffering");
     }
 }

framework/quota/src/test/java/org/apache/cloudstack/quota/activationrule/presetvariables/PresetVariableHelperTest.java

@@ -1308,7 +1308,6 @@ public void getPresetVariableValueNetworkOfferingTestSetValuesAndReturnObject()
         GenericPresetVariable result = presetVariableHelperSpy.getPresetVariableValueNetworkOffering(1L);
 
         assertPresetVariableIdAndName(expected, result);
-        validateFieldNamesToIncludeInToString(Arrays.asList("id", "name"), result);
     }
 
     @Test
@@ -1324,6 +1323,5 @@ public void getPresetVariableValueVpcOfferingTestSetValuesAndReturnObject() {
         GenericPresetVariable result = presetVariableHelperSpy.getPresetVariableValueVpcOffering(1L);
 
         assertPresetVariableIdAndName(expected, result);
-        validateFieldNamesToIncludeInToString(Arrays.asList("id", "name"), result);
     }
 }