Block backup deletion while create-VM-from-backup or restore jobs are in progress

Author: Damans227

server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java

@@ -1529,6 +1529,8 @@ public boolean deleteBackup(final Long backupId, final Boolean forced) {
         }
         logger.debug("Deleting backup {} belonging to instance {}", backup.toString(), vmId);
 
+        checkForPendingBackupJobs(backup);
+
         validateBackupForZone(backup.getZoneId());
         accountManager.checkAccess(CallContext.current().getCallingAccount(), null, true, vm == null ? backup : vm);
         final BackupOffering offering = backupOfferingDao.findByIdIncludingRemoved(backup.getBackupOfferingId());
@@ -1551,6 +1553,17 @@ public boolean deleteBackup(final Long backupId, final Boolean forced) {
         throw new CloudRuntimeException("Failed to delete the backup");
     }
 
+    private void checkForPendingBackupJobs(final BackupVO backup) {
+        String backupUuid = backup.getUuid();
+        long pendingJobs = asyncJobManager.countPendingJobs(backupUuid,
+                CreateVMFromBackupCmd.class.getName(),
+                CreateVMFromBackupCmdByAdmin.class.getName(),
+                RestoreBackupCmd.class.getName());
+        if (pendingJobs > 0) {
+            throw new CloudRuntimeException("Cannot delete backup while a create instance from backup or restore operation is in progress, please try again later.");
+        }
+    }
+
     /**
      * Get the pair: hostIp, datastoreUuid in which to restore the volume, based on the VM to be attached information
      */