address review comments

Author: sudo87

api/src/main/java/com/cloud/agent/api/storage/OVFHelper.java

@@ -335,7 +335,7 @@ protected List<OVFDisk> extractDisksFromOvfDocumentTree(Document doc) {
             vd.add(od);
         }
         if (logger.isTraceEnabled()) {
-            logger.trace(String.format("found %d disk definitions",vd.size()));
+            logger.trace(String.format("Found %d disk definitions", vd.size()));
         }
         return vd;
     }
@@ -367,7 +367,7 @@ protected List<OVFFile> extractFilesFromOvfDocumentTree(File ovfFile, Document d
             }
         }
         if (logger.isTraceEnabled()) {
-            logger.trace(String.format("found %d file definitions in %s",vf.size(), ovfFile.getPath()));
+            logger.trace(String.format("Found %d file definitions in %s", vf.size(), ovfFile.getPath()));
         }
         return vf;
     }

api/src/main/java/org/apache/cloudstack/api/command/admin/acl/CreateRoleCmd.java

@@ -101,15 +101,15 @@ public void execute() {
 
     private void validateRoleParameters() {
         if (getRoleType() == null && getRoleId() == null) {
-            throw new ServerApiException(ApiErrorCode.PARAM_ERROR, "Neither role type nor role id is provided");
+            throw new ServerApiException(ApiErrorCode.PARAM_ERROR, "Neither role type nor role ID is provided");
         }
 
         if (getRoleType() != null && getRoleId() != null) {
-            throw new ServerApiException(ApiErrorCode.PARAM_ERROR, "Both role type and role id should not be specified");
+            throw new ServerApiException(ApiErrorCode.PARAM_ERROR, "Both role type and role ID should not be specified");
         }
 
         if (getRoleId() != null && getRoleId() < 1L) {
-            throw new ServerApiException(ApiErrorCode.PARAM_ERROR, "Invalid role id provided");
+            throw new ServerApiException(ApiErrorCode.PARAM_ERROR, "Invalid role ID provided");
         }
     }
 

api/src/main/java/org/apache/cloudstack/api/command/admin/address/ReleasePodIpCmdByAdmin.java

@@ -70,7 +70,7 @@ public void execute() {
             response.setDisplayText("IP is released successfully");
             setResponseObject(response);
         } else {
-            throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, "Failed to release Pod ip ");
+            throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, "Failed to release Pod IP");
         }
     }
 }

api/src/main/java/org/apache/cloudstack/api/command/admin/annotation/AddAnnotationCmd.java

@@ -44,7 +44,7 @@ public class AddAnnotationCmd extends BaseCmd {
     @Parameter(name = ApiConstants.ENTITY_TYPE, type = CommandType.STRING, description = "The following entity types are allowed VM, VOLUME, SNAPSHOT, VM_SNAPSHOT, INSTANCE_GROUP, SSH_KEYPAIR, USER_DATA, NETWORK, VPC, PUBLIC_IP_ADDRESS, VPN_CUSTOMER_GATEWAY, TEMPLATE, ISO, KUBERNETES_CLUSTER, SERVICE_OFFERING, DISK_OFFERING, NETWORK_OFFERING, ZONE, POD, CLUSTER, HOST, DOMAIN, PRIMARY_STORAGE, SECONDARY_STORAGE, VR, SYSTEM_VM, AUTOSCALE_VM_GROUP, MANAGEMENT_SERVER")
     private String entityType;
 
-    @Parameter(name = ApiConstants.ENTITY_ID, type = CommandType.STRING, description = "The id of the entity to annotate")
+    @Parameter(name = ApiConstants.ENTITY_ID, type = CommandType.STRING, description = "The ID of the entity to annotate")
     private String entityUuid;
 
     @Parameter(name = ApiConstants.ADMINS_ONLY, type = CommandType.BOOLEAN, since = "4.16.0",

api/src/main/java/org/apache/cloudstack/api/command/admin/annotation/ListAnnotationsCmd.java

@@ -37,17 +37,17 @@
 public class ListAnnotationsCmd extends BaseListCmd {
 
 
-    @Parameter(name = ApiConstants.ID, type = CommandType.STRING, description = "The id of the annotation")
+    @Parameter(name = ApiConstants.ID, type = CommandType.STRING, description = "The ID of the annotation")
     private String uuid;
 
     @Parameter(name = ApiConstants.ENTITY_TYPE, type = CommandType.STRING, description = "The entity type")
     private String entityType;
 
-    @Parameter(name = ApiConstants.ENTITY_ID, type = CommandType.STRING, description = "The id of the entity for which to show annotations")
+    @Parameter(name = ApiConstants.ENTITY_ID, type = CommandType.STRING, description = "The ID of the entity for which to show annotations")
     private String entityUuid;
 
     @Parameter(name = ApiConstants.USER_ID, type = CommandType.STRING, since = "4.16.0",
-            description = "Optional: The id of the user of the annotation", required = false)
+            description = "Optional: The ID of the user of the annotation", required = false)
     private String userUuid;
 
     @Parameter(name = ApiConstants.ANNOTATION_FILTER,

api/src/main/java/org/apache/cloudstack/api/command/admin/annotation/UpdateAnnotationVisibilityCmd.java

@@ -38,7 +38,7 @@ public class UpdateAnnotationVisibilityCmd extends BaseCmd {
 
 
     @Parameter(name = ApiConstants.ID, type = CommandType.STRING, required = true,
-            description = "The id of the annotation")
+            description = "The ID of the annotation")
     private String uuid;
 
     @Parameter(name = ApiConstants.ADMINS_ONLY, type = CommandType.BOOLEAN, required = true,

api/src/main/java/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java

@@ -85,7 +85,7 @@ public class AddClusterCmd extends BaseCmd {
     @Parameter(name = ApiConstants.VSM_PASSWORD, type = CommandType.STRING, required = false, description = "The password for the VSM associated with this cluster")
     private String vsmpassword;
 
-    @Parameter(name = ApiConstants.VSM_IPADDRESS, type = CommandType.STRING, required = false, description = "The ipaddress of the VSM associated with this cluster")
+    @Parameter(name = ApiConstants.VSM_IPADDRESS, type = CommandType.STRING, required = false, description = "The IP address of the VSM associated with this cluster")
     private String vsmipaddress;
 
     @Parameter(name = ApiConstants.VSWITCH_TYPE_GUEST_TRAFFIC,

api/src/main/java/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java

@@ -54,7 +54,7 @@ public class ListHostsCmd extends BaseListCmd {
     @Parameter(name = ApiConstants.CLUSTER_ID, type = CommandType.UUID, entityType = ClusterResponse.class, description = "Lists hosts existing in particular cluster")
     private Long clusterId;
 
-    @Parameter(name = ApiConstants.ID, type = CommandType.UUID, entityType = HostResponse.class, description = "The id of the host")
+    @Parameter(name = ApiConstants.ID, type = CommandType.UUID, entityType = HostResponse.class, description = "The ID of the host")
     private Long id;
 
     @Parameter(name = ApiConstants.NAME, type = CommandType.STRING, description = "The name of the host")

api/src/main/java/org/apache/cloudstack/api/command/admin/host/UpdateHostCmd.java

@@ -47,7 +47,7 @@ public class UpdateHostCmd extends BaseCmd {
     @Parameter(name = ApiConstants.OS_CATEGORY_ID,
                type = CommandType.UUID,
                entityType = GuestOSCategoryResponse.class,
-               description = "The id of Os category to update the host with")
+               description = "The ID of Os category to update the host with")
     private Long osCategoryId;
 
     @Parameter(name = ApiConstants.ALLOCATION_STATE,
@@ -61,7 +61,7 @@ public class UpdateHostCmd extends BaseCmd {
     @Parameter(name = ApiConstants.IS_TAG_A_RULE, type = CommandType.BOOLEAN, description = ApiConstants.PARAMETER_DESCRIPTION_IS_TAG_A_RULE)
     private Boolean isTagARule;
 
-    @Parameter(name = ApiConstants.URL, type = CommandType.STRING, description = "The new uri for the secondary storage: nfs://host/path")
+    @Parameter(name = ApiConstants.URL, type = CommandType.STRING, description = "The new URI for the secondary storage: nfs://host/path")
     private String url;
 
     @Parameter(name = ApiConstants.ANNOTATION, type = CommandType.STRING, description = "Add an annotation to this host", since = "4.11", authorized = {RoleType.Admin})

api/src/main/java/org/apache/cloudstack/api/command/admin/internallb/ListInternalLoadBalancerElementsCmd.java

@@ -50,13 +50,13 @@ public class ListInternalLoadBalancerElementsCmd extends BaseListCmd {
     @Parameter(name = ApiConstants.ID,
                type = CommandType.UUID,
                entityType = InternalLoadBalancerElementResponse.class,
-               description = "List internal load balancer elements by id")
+               description = "List internal load balancer elements by ID")
     private Long id;
 
     @Parameter(name = ApiConstants.NSP_ID,
                type = CommandType.UUID,
                entityType = ProviderResponse.class,
-               description = "List internal load balancer elements by network service provider id")
+               description = "List internal load balancer elements by network service provider ID")
     private Long nspId;
 
     @Parameter(name = ApiConstants.ENABLED, type = CommandType.BOOLEAN, description = "List internal load balancer elements by enabled state")