fix: support SharedMountPoint volume checks for importVm

Author: prashanthr2

plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCheckVolumeCommandWrapper.java

@@ -39,15 +39,17 @@
 import org.apache.commons.lang3.StringUtils;
 import org.libvirt.LibvirtException;
 
-import java.util.Arrays;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 
 @ResourceWrapper(handles = CheckVolumeCommand.class)
 public final class LibvirtCheckVolumeCommandWrapper extends CommandWrapper<CheckVolumeCommand, Answer, LibvirtComputingResource> {
 
-    private static final List<Storage.StoragePoolType> STORAGE_POOL_TYPES_SUPPORTED = Arrays.asList(Storage.StoragePoolType.Filesystem, Storage.StoragePoolType.NetworkFilesystem);
+    private static final List<Storage.StoragePoolType> STORAGE_POOL_TYPES_SUPPORTED = List.of(
+            Storage.StoragePoolType.Filesystem,
+            Storage.StoragePoolType.NetworkFilesystem,
+            Storage.StoragePoolType.SharedMountPoint);
 
     @Override
     public Answer execute(final CheckVolumeCommand command, final LibvirtComputingResource libvirtComputingResource) {

plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCheckVolumeCommandWrapperTest.java

@@ -0,0 +1,116 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.hypervisor.kvm.resource.wrapper;
+
+import java.util.Map;
+
+import org.apache.cloudstack.utils.qemu.QemuImg;
+import org.apache.cloudstack.utils.qemu.QemuImgFile;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.Mock;
+import org.mockito.MockedConstruction;
+import org.mockito.MockedStatic;
+import org.mockito.Mockito;
+import org.mockito.junit.MockitoJUnitRunner;
+
+import com.cloud.agent.api.Answer;
+import com.cloud.agent.api.CheckVolumeAnswer;
+import com.cloud.agent.api.CheckVolumeCommand;
+import com.cloud.agent.api.to.StorageFilerTO;
+import com.cloud.hypervisor.kvm.resource.LibvirtComputingResource;
+import com.cloud.hypervisor.kvm.storage.KVMPhysicalDisk;
+import com.cloud.hypervisor.kvm.storage.KVMStoragePool;
+import com.cloud.hypervisor.kvm.storage.KVMStoragePoolManager;
+import com.cloud.storage.Storage;
+
+@RunWith(MockitoJUnitRunner.class)
+public class LibvirtCheckVolumeCommandWrapperTest {
+
+    private static final String SOURCE_FILE = "disk.qcow2";
+    private static final String DISK_PATH = "/mnt/primary/disk.qcow2";
+    private static final String POOL_UUID = "pool-uuid";
+    private static final long DISK_SIZE = 1024L;
+
+    @Mock
+    private LibvirtComputingResource libvirtComputingResource;
+
+    @Mock
+    private KVMStoragePoolManager storagePoolMgr;
+
+    @Mock
+    private KVMStoragePool storagePool;
+
+    @Mock
+    private StorageFilerTO storageFilerTO;
+
+    @Mock
+    private KVMPhysicalDisk physicalDisk;
+
+    @Mock
+    private CheckVolumeCommand command;
+
+    private final LibvirtCheckVolumeCommandWrapper wrapper = new LibvirtCheckVolumeCommandWrapper();
+
+    @Before
+    public void setUp() {
+        Mockito.when(command.getSrcFile()).thenReturn(SOURCE_FILE);
+        Mockito.when(command.getStorageFilerTO()).thenReturn(storageFilerTO);
+        Mockito.when(storageFilerTO.getUuid()).thenReturn(POOL_UUID);
+        Mockito.when(libvirtComputingResource.getStoragePoolMgr()).thenReturn(storagePoolMgr);
+    }
+
+    @Test
+    public void testExecuteSupportsSharedMountPointStorage() throws Exception {
+        Mockito.when(storageFilerTO.getType()).thenReturn(Storage.StoragePoolType.SharedMountPoint);
+        Mockito.when(storagePoolMgr.getStoragePool(Storage.StoragePoolType.SharedMountPoint, POOL_UUID)).thenReturn(storagePool);
+        Mockito.when(storagePool.getPhysicalDisk(SOURCE_FILE)).thenReturn(physicalDisk);
+        Mockito.when(storagePool.getType()).thenReturn(Storage.StoragePoolType.SharedMountPoint);
+        Mockito.when(physicalDisk.getPath()).thenReturn(DISK_PATH);
+        Mockito.when(physicalDisk.getFormat()).thenReturn(QemuImg.PhysicalDiskFormat.QCOW2);
+
+        try (MockedStatic<KVMPhysicalDisk> diskMock = Mockito.mockStatic(KVMPhysicalDisk.class);
+                MockedConstruction<QemuImg> ignored = Mockito.mockConstruction(QemuImg.class, (mock, context) ->
+                        Mockito.when(mock.info(Mockito.any(QemuImgFile.class), Mockito.anyBoolean())).thenReturn(Map.of()))) {
+            diskMock.when(() -> KVMPhysicalDisk.checkQcow2File(DISK_PATH)).thenAnswer(invocation -> null);
+            diskMock.when(() -> KVMPhysicalDisk.getVirtualSizeFromFile(DISK_PATH)).thenReturn(DISK_SIZE);
+
+            Answer answer = wrapper.execute(command, libvirtComputingResource);
+
+            Assert.assertTrue(answer instanceof CheckVolumeAnswer);
+            Assert.assertTrue(answer.getResult());
+            Assert.assertEquals(DISK_SIZE, ((CheckVolumeAnswer) answer).getSize());
+        }
+    }
+
+    @Test
+    public void testExecuteRejectsUnsupportedStoragePoolType() {
+        Mockito.when(storageFilerTO.getType()).thenReturn(Storage.StoragePoolType.RBD);
+        Mockito.when(storagePoolMgr.getStoragePool(Storage.StoragePoolType.RBD, POOL_UUID)).thenReturn(storagePool);
+
+        Answer answer = wrapper.execute(command, libvirtComputingResource);
+
+        Assert.assertFalse(answer.getResult());
+        Assert.assertEquals("Unsupported Storage Pool", answer.getDetails());
+        Mockito.verify(storagePool, Mockito.never()).getPhysicalDisk(Mockito.anyString());
+    }
+}