Use sudo only for non-root user

Author: vishesh92

server/src/main/java/org/apache/cloudstack/ca/CAManagerImpl.java

@@ -323,8 +323,9 @@ private boolean provisionKvmHostViaSsh(Host host, String caProvider) {
 
             provisionCertificateViaSsh(sshConnection, hostIp, host.getName(), caProvider);
 
-            SSHCmdHelper.sshExecuteCmd(sshConnection, "sudo systemctl restart libvirtd");
-            SSHCmdHelper.sshExecuteCmd(sshConnection, "sudo systemctl restart cloudstack-agent");
+            String sudoPrefix = "root".equals(username) ? "" : "sudo ";
+            SSHCmdHelper.sshExecuteCmd(sshConnection, sudoPrefix + "systemctl restart libvirtd");
+            SSHCmdHelper.sshExecuteCmd(sshConnection, sudoPrefix + "systemctl restart cloudstack-agent");
 
             return true;
         } catch (Exception e) {

server/src/test/java/org/apache/cloudstack/ca/CAManagerImplTest.java

@@ -290,8 +290,8 @@ public void testProvisionKvmHostViaSsh() throws Exception {
 
             Assert.assertTrue(result);
             Mockito.verify(caManager, Mockito.times(1)).provisionCertificateViaSsh(Mockito.any(Connection.class), Mockito.eq("192.168.1.1"), Mockito.eq("host1"), Mockito.eq("root"));
-            sshCmdHelperMock.verify(() -> SSHCmdHelper.sshExecuteCmd(Mockito.any(Connection.class), Mockito.eq("sudo service libvirtd restart")), Mockito.times(1));
-            sshCmdHelperMock.verify(() -> SSHCmdHelper.sshExecuteCmd(Mockito.any(Connection.class), Mockito.eq("sudo service cloudstack-agent restart")), Mockito.times(1));
+            sshCmdHelperMock.verify(() -> SSHCmdHelper.sshExecuteCmd(Mockito.any(Connection.class), Mockito.eq("systemctl restart libvirtd")), Mockito.times(1));
+            sshCmdHelperMock.verify(() -> SSHCmdHelper.sshExecuteCmd(Mockito.any(Connection.class), Mockito.eq("systemctl restart cloudstack-agent")), Mockito.times(1));
         }
     }