address possible npe

Pearl1594 · Pearl1594 · commit f4baae44171e · 2026-02-09T09:45:42.000-05:00
diff --git a/server/src/main/java/org/apache/cloudstack/region/gslb/GlobalLoadBalancingRulesServiceImpl.java b/server/src/main/java/org/apache/cloudstack/region/gslb/GlobalLoadBalancingRulesServiceImpl.java
@@ -21,6 +21,7 @@
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
+import java.util.Objects;
 
 import javax.inject.Inject;
 
@@ -681,7 +682,7 @@ private boolean applyGlobalLoadBalancerRuleConfig(long gslbRuleId, boolean revok
                     continue;
                 }
                 SiteLoadBalancerConfig siteLb = zoneSiteLoadbalancerMap.get(innerLoopZoneId.first());
-                siteLb.setLocal(zoneId.first().equals(innerLoopZoneId.first()));
+                siteLb.setLocal(Objects.equals(zoneId.first(), innerLoopZoneId.first()));
                 slbs.add(siteLb);
             }
 

Original file line number	Diff line number	Diff line change
`@@ -21,6 +21,7 @@`
`21`	`21`	`import java.util.HashMap;`
`22`	`22`	`import java.util.List;`
`23`	`23`	`import java.util.Map;`
	`24`	`+import java.util.Objects;`
`24`	`25`
`25`	`26`	`import javax.inject.Inject;`
`26`	`27`
`@@ -681,7 +682,7 @@ private boolean applyGlobalLoadBalancerRuleConfig(long gslbRuleId, boolean revok`
`681`	`682`	`continue;`
`682`	`683`	`}`
`683`	`684`	`SiteLoadBalancerConfig siteLb = zoneSiteLoadbalancerMap.get(innerLoopZoneId.first());`
`684`		`- siteLb.setLocal(zoneId.first().equals(innerLoopZoneId.first()));`
	`685`	`+ siteLb.setLocal(Objects.equals(zoneId.first(), innerLoopZoneId.first()));`
`685`	`686`	`slbs.add(siteLb);`
`686`	`687`	`}`
`687`	`688`