Skip to content

address review comments

d013c2f
Select commit
Loading
Failed to load commit list.
Merged

Fix restore from NAS backup when datadisk is older than the root disk. #11258

address review comments
d013c2f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 23, 2025 in 1s

16.15% (+0.00%) compared to ba0204f

View this Pull Request on Codecov

16.15% (+0.00%) compared to ba0204f

Details

Codecov Report

Attention: Patch coverage is 12.82051% with 34 lines in your changes missing coverage. Please review.

Project coverage is 16.15%. Comparing base (ba0204f) to head (d013c2f).
Report is 24 commits behind head on 4.20.

Files with missing lines Patch % Lines
...ce/wrapper/LibvirtRestoreBackupCommandWrapper.java 0.00% 28 Missing ⚠️
...rg/apache/cloudstack/backup/NASBackupProvider.java 0.00% 5 Missing ⚠️
...rg/apache/cloudstack/backup/BackupManagerImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               4.20   #11258    +/-   ##
==========================================
  Coverage     16.15%   16.15%            
+ Complexity    13277    13274     -3     
==========================================
  Files          5657     5656     -1     
  Lines        497939   497811   -128     
  Branches      60386    60372    -14     
==========================================
- Hits          80443    80436     -7     
+ Misses       408532   408423   -109     
+ Partials       8964     8952    -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.