Skip to content

Validate qcow2 file during import operation #11264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaanHoogland merged 4 commits into from
Jul 25, 2025

Check imported volume details, throw appropriate error for locked or …

210a3f2
Select commit
Loading
Failed to load commit list.
Merged

Validate qcow2 file during import operation #11264

Check imported volume details, throw appropriate error for locked or …
210a3f2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 24, 2025 in 0s

15.17% (-0.01%) compared to 3fc02dd, passed because coverage increased by 0% when compared to adjusted base (15.18%)

View this Pull Request on Codecov

15.17% (-0.01%) compared to 3fc02dd, passed because coverage increased by 0% when compared to adjusted base (15.18%)

Details

Codecov Report

Attention: Patch coverage is 16.57143% with 146 lines in your changes missing coverage. Please review.

Project coverage is 15.17%. Comparing base (3fc02dd) to head (210a3f2).
Report is 1 commits behind head on 4.19.

Files with missing lines Patch % Lines
...urce/wrapper/LibvirtCheckVolumeCommandWrapper.java 2.22% 44 Missing ⚠️
...wrapper/LibvirtCopyRemoteVolumeCommandWrapper.java 2.27% 43 Missing ⚠️
.../cloud/hypervisor/kvm/storage/KVMPhysicalDisk.java 0.00% 19 Missing ⚠️
.../apache/cloudstack/vm/UnmanagedVMsManagerImpl.java 28.00% 15 Missing and 3 partials ⚠️
...pper/LibvirtGetVolumesOnStorageCommandWrapper.java 64.51% 3 Missing and 8 partials ⚠️
...in/java/com/cloud/agent/api/CheckVolumeAnswer.java 0.00% 5 Missing ⚠️
...va/com/cloud/agent/api/CopyRemoteVolumeAnswer.java 0.00% 5 Missing ⚠️
...rce/wrapper/LibvirtResizeVolumeCommandWrapper.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               4.19   #11264      +/-   ##
============================================
- Coverage     15.18%   15.17%   -0.01%     
+ Complexity    11367    11363       -4     
============================================
  Files          5415     5415              
  Lines        475910   476025     +115     
  Branches      58099    58114      +15     
============================================
- Hits          72254    72246       -8     
- Misses       395569   395696     +127     
+ Partials       8087     8083       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov