Skip to content

remove redunant domainId check

a487eba
Select commit
Loading
Failed to load commit list.
Merged

Skip removal of offerings if in use during domain removal #11780

remove redunant domainId check
a487eba
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 6, 2026 in 0s

16.30% (+0.11%) compared to d53b6db

View this Pull Request on Codecov

16.30% (+0.11%) compared to d53b6db

Details

Codecov Report

❌ Patch coverage is 8.51064% with 43 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.30%. Comparing base (d53b6db) to head (a487eba).
⚠️ Report is 33 commits behind head on 4.20.

Files with missing lines Patch % Lines
.../main/java/com/cloud/vm/dao/VMInstanceDaoImpl.java 0.00% 26 Missing ⚠️
...rc/main/java/com/cloud/user/DomainManagerImpl.java 0.00% 8 Missing ⚠️
...main/java/com/cloud/storage/dao/VolumeDaoImpl.java 40.00% 6 Missing ⚠️
.../cloud/configuration/ConfigurationManagerImpl.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               4.20   #11780      +/-   ##
============================================
+ Coverage     16.19%   16.30%   +0.11%     
- Complexity    13306    13427     +121     
============================================
  Files          5657     5657              
  Lines        498467   503719    +5252     
  Branches      60491    62373    +1882     
============================================
+ Hits          80702    82117    +1415     
- Misses       408783   412537    +3754     
- Partials       8982     9065      +83     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.