Skip to content

Support dedicating backup offerings to domains #12194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harikrishna-patnala merged 21 commits into from
Jan 19, 2026

allow updating backup offering when only domain id is modified

ce0d334
Select commit
Loading
Failed to load commit list.
Merged

Support dedicating backup offerings to domains #12194

allow updating backup offering when only domain id is modified
ce0d334
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 7, 2026 in 0s

17.79% (+0.03%) compared to eedd329

View this Pull Request on Codecov

17.79% (+0.03%) compared to eedd329

Details

Codecov Report

❌ Patch coverage is 54.72313% with 139 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.79%. Comparing base (eedd329) to head (ce0d334).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rg/apache/cloudstack/backup/BackupManagerImpl.java 63.88% 15 Missing and 11 partials ⚠️
...er/src/main/java/com/cloud/utils/DomainHelper.java 0.00% 19 Missing ⚠️
...e/cloudstack/backup/dao/BackupOfferingDaoImpl.java 0.00% 13 Missing ⚠️
...ver/src/main/java/com/cloud/acl/DomainChecker.java 47.61% 4 Missing and 7 partials ⚠️
.../api/command/offering/DomainAndZoneIdResolver.java 78.72% 0 Missing and 10 partials ⚠️
...c/main/java/com/cloud/user/AccountManagerImpl.java 0.00% 10 Missing ⚠️
.../command/admin/backup/ImportBackupOfferingCmd.java 0.00% 7 Missing ⚠️
...che/cloudstack/backup/BackupOfferingDetailsVO.java 75.00% 6 Missing and 1 partial ⚠️
...loudstack/api/response/BackupOfferingResponse.java 0.00% 6 Missing ⚠️
.../command/admin/backup/UpdateBackupOfferingCmd.java 37.50% 3 Missing and 2 partials ⚠️
... and 9 more
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #12194      +/-   ##
============================================
+ Coverage     17.75%   17.79%   +0.03%     
- Complexity    15855    15910      +55     
============================================
  Files          5923     5927       +4     
  Lines        530536   530658     +122     
  Branches      64826    64835       +9     
============================================
+ Hits          94218    94434     +216     
+ Misses       425774   425652     -122     
- Partials      10544    10572      +28

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov