Skip to content

kvm: do not add disk cache mode from an empty string#12248

Merged
Pearl1594 merged 1 commit intoapache:4.20from
shapeblue:d12226-cacheEnumError
Jan 26, 2026
Merged

kvm: do not add disk cache mode from an empty string#12248
Pearl1594 merged 1 commit intoapache:4.20from
shapeblue:d12226-cacheEnumError

Conversation

@DaanHoogland
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland commented Dec 12, 2025

Description

This PR fixes a bug discussed in #12226 (comment)

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

weizhouapache
weizhouapache approved these changes Dec 12, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

I will test it

@weizhouapache weizhouapache self-assigned this Dec 12, 2025
@DaanHoogland DaanHoogland changed the title do not add disk cache mode from an empty string kvm: do not add disk cache mode from an empty string Dec 12, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 12, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.23%. Comparing base (aba3285) to head (a573bed).
⚠️ Report is 30 commits behind head on 4.20.

Files with missing lines Patch % Lines
...ypervisor/kvm/resource/LibvirtDomainXMLParser.java 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               4.20   #12248      +/-   ##
============================================
- Coverage     16.23%   16.23%   -0.01%     
+ Complexity    13382    13380       -2     
============================================
  Files          5657     5657              
  Lines        498997   498998       +1     
  Branches      60566    60567       +1     
============================================
- Hits          81032    81028       -4     
- Misses       408929   408934       +5     
  Partials       9036     9036
Flag Coverage Δ
uitests 4.03% <ø> (ø)
unittests 17.09% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@weizhouapache
Copy link
Copy Markdown
Member

weizhouapache commented Dec 12, 2025

@blueorangutan package

sureshanaparti
sureshanaparti approved these changes Dec 12, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@weizhouapache
Copy link
Copy Markdown
Member

weizhouapache commented Dec 12, 2025

@blueorangutan test

@weizhouapache
Copy link
Copy Markdown
Member

weizhouapache commented Dec 23, 2025

@blueorangutan test

@abh1sar abh1sar added this to the 4.20.3 milestone Jan 7, 2026
vishesh92
vishesh92 approved these changes Jan 15, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland DaanHoogland force-pushed the d12226-cacheEnumError branch from d7ddc18 to a573bed Compare January 15, 2026 10:05
@DaanHoogland
Copy link
Copy Markdown
Contributor Author

DaanHoogland commented Jan 15, 2026

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 15, 2026

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@apache apache deleted a comment from blueorangutan Jan 15, 2026
@apache apache deleted a comment from blueorangutan Jan 15, 2026
@apache apache deleted a comment from blueorangutan Jan 15, 2026
@apache apache deleted a comment from blueorangutan Jan 15, 2026
@apache apache deleted a comment from blueorangutan Jan 15, 2026
@apache apache deleted a comment from blueorangutan Jan 15, 2026
@apache apache deleted a comment from blueorangutan Jan 15, 2026
@apache apache deleted a comment from blueorangutan Jan 15, 2026
@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 15, 2026

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16378

@DaanHoogland
Copy link
Copy Markdown
Contributor Author

DaanHoogland commented Jan 15, 2026

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 15, 2026

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 16, 2026

[SF] Trillian test result (tid-15190)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 49704 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12248-t15190-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@DaanHoogland
Copy link
Copy Markdown
Contributor Author

DaanHoogland commented Jan 16, 2026

code lgtm

I will test it

will you still see a chance to test this, @weizhouapache ?

Pearl1594
Pearl1594 approved these changes Jan 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested - LGTM. Added debugger and forced diskCacheMode to "" and was able to destroy/expunge a VM successfully.

@Pearl1594 Pearl1594 merged commit fa3dee8 into apache:4.20 Jan 26, 2026
25 of 26 checks passed
@Pearl1594 Pearl1594 deleted the d12226-cacheEnumError branch January 26, 2026 14:35
sandeeplocharla pushed a commit to NetApp/cloudstack that referenced this pull request Feb 6, 2026
@DaanHoogland
do not add disk cache mode from an empty string (apache#12248)
b04b1b0 
Co-authored-by: Daan Hoogland <dahn@apache.org>
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Mar 3, 2026
@DaanHoogland @dhslove
do not add disk cache mode from an empty string (apache#12248)
84badc0 
Co-authored-by: Daan Hoogland <dahn@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vishesh92 vishesh92 vishesh92 approved these changes

@Pearl1594 Pearl1594 Pearl1594 approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

Assignees

@weizhouapache weizhouapache

Labels

component:kvm

Projects

None yet

Milestone

4.20.3

Development

Successfully merging this pull request may close these issues.

7 participants

@DaanHoogland @weizhouapache @blueorangutan @vishesh92 @Pearl1594 @sureshanaparti @abh1sar