Skip to content

CKS: Fix issue with scaling down CKS Nodes when deployed in HA mode #12302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaanHoogland merged 2 commits into from
Dec 30, 2025
Merged

CKS: Fix issue with scaling down CKS Nodes when deployed in HA mode #12302

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2affeaf
CKS: Fix issue with scaling down CKS Nodes when deployed in HA mode
Pearl1594 Dec 19, 2025
dd07d7d
extract code and add unit tests
Pearl1594 Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions ...rc/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterScaleWorker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,11 +441,19 @@ private void scaleDownKubernetesClusterSize() throws CloudRuntimeException {
if (this.nodeIds != null) {
vmList = getKubernetesClusterVMMapsForNodes(this.nodeIds).stream().filter(vm -> !vm.isExternalNode()).collect(Collectors.toList());
} else {
vmList = getKubernetesClusterVMMaps();
vmList = vmList.stream()
List<KubernetesClusterVmMapVO> workerVMsMap = getKubernetesClusterVMMaps().stream()
.filter(vm -> !vm.isExternalNode() && !vm.isControlNode() && !vm.isEtcdNode())
.collect(Collectors.toList());
vmList = vmList.subList((int) (kubernetesCluster.getControlNodeCount() + clusterSize - 1), vmList.size());
int totalWorkerNodes = workerVMsMap.size();
int desiredWorkerNodes = clusterSize == null ? (int) kubernetesCluster.getNodeCount() : clusterSize.intValue();
int toRemoveCount = Math.max(0, totalWorkerNodes - desiredWorkerNodes);
if (toRemoveCount == 0) {
logger.info("No nodes to remove from Kubernetes cluster: {}", kubernetesCluster);
return;
}

int startIndex = Math.max(0, totalWorkerNodes - toRemoveCount);
vmList = new ArrayList<>(workerVMsMap.subList(startIndex, totalWorkerNodes));
}
Collections.reverse(vmList);
removeNodesFromCluster(vmList);
Expand Down
Loading