Skip to content

Cleanup snapshot files in datastores for Error-ed snapshots, and some code improvements #12347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaanHoogland merged 3 commits into from
Jan 15, 2026

event fix

2305550
Select commit
Loading
Failed to load commit list.
Merged

Cleanup snapshot files in datastores for Error-ed snapshots, and some code improvements #12347

event fix
2305550
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 2, 2026 in 0s

16.23% (+0.00%) compared to 4f74937

View this Pull Request on Codecov

16.23% (+0.00%) compared to 4f74937

Details

Codecov Report

❌ Patch coverage is 2.17391% with 90 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.23%. Comparing base (4f74937) to head (2305550).

Files with missing lines Patch % Lines
...ain/java/com/cloud/storage/StorageManagerImpl.java 0.00% 44 Missing ⚠️
...tack/storage/snapshot/SnapshotDataFactoryImpl.java 0.00% 14 Missing ⚠️
...om/cloud/storage/snapshot/SnapshotManagerImpl.java 7.14% 13 Missing ⚠️
...in/java/com/cloud/storage/dao/SnapshotDaoImpl.java 0.00% 5 Missing ⚠️
...storage/datastore/db/SnapshotDataStoreDaoImpl.java 0.00% 5 Missing ⚠️
...torage/datastore/ObjectInDataStoreManagerImpl.java 0.00% 3 Missing ⚠️
...oudstack/storage/snapshot/SnapshotServiceImpl.java 0.00% 2 Missing ⚠️
...ack/storage/snapshot/StorPoolSnapshotStrategy.java 0.00% 2 Missing ⚠️
...tack/storage/snapshot/DefaultSnapshotStrategy.java 50.00% 1 Missing ⚠️
...udstack/storage/datastore/util/StorPoolHelper.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##               4.20   #12347   +/-   ##
=========================================
  Coverage     16.23%   16.23%           
- Complexity    13375    13379    +4     
=========================================
  Files          5657     5657           
  Lines        498875   498902   +27     
  Branches      60546    60542    -4     
=========================================
+ Hits          80982    81019   +37     
+ Misses       408866   408850   -16     
- Partials       9027     9033    +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov