Skip to content

Changes to the error message displayed during the removal of public templates that are used #12373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaanHoogland merged 3 commits into from
Feb 23, 2026
+10 −4
Merged

Changes to the error message displayed during the removal of public templates that are used #12373

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f9e815e
Changes to the error message displayed during the removal of public t…
erikbocks Feb 3, 2026
a83bb4c
add instances count to message
erikbocks Feb 14, 2026
dfc69f3
Address suggestions
erikbocks Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions server/src/main/java/com/cloud/template/TemplateManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,6 @@
import com.cloud.vm.VmDetailConstants;
import com.cloud.vm.dao.UserVmDao;
import com.cloud.vm.dao.VMInstanceDao;
import com.google.common.base.Joiner;
import com.google.gson.Gson;
import com.google.gson.GsonBuilder;

Expand Down Expand Up @@ -1376,8 +1375,15 @@ public boolean deleteTemplate(DeleteTemplateCmd cmd) {
vmInstanceVOList = _vmInstanceDao.listNonExpungedByTemplate(templateId);
}
if(!cmd.isForced() && CollectionUtils.isNotEmpty(vmInstanceVOList)) {
Comment thread
erikbocks marked this conversation as resolved.
Outdated
final String message = String.format("Unable to delete Template: %s because Instance: [%s] are using it.", template, Joiner.on(",").join(vmInstanceVOList));
logger.warn(message);
String message = String.format("Unable to delete template with ID %s, because there are VM instances using it.", template);
String instancesListMessage = String.format(" Instances list: [%s].", StringUtils.join(vmInstanceVOList, ","));

Comment thread
erikbocks marked this conversation as resolved.
logger.warn("{}{}", message, instancesListMessage);

if (_accountMgr.isRootAdmin(caller.getAccountId())) {
message += instancesListMessage;
}

throw new InvalidParameterValueException(message);
}

Expand Down
Loading