Fix for Deleted userdata owned by a deleted account remains linked with the template

[nvazquez]

Description

This PR fixes an issue in which an account removed userdata remains linked to a template, after the account deletion (and its userdata).

Fixes: #9477

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[nvazquez]

@blueorangutan package

[blueorangutan]

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 4.03%. Comparing base (f1f779a) to head (505faf7).
⚠️ Report is 9 commits behind head on 4.20.

❗ There is a different number of reports uploaded between BASE (f1f779a) and HEAD (505faf7). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (f1f779a)	HEAD (505faf7)
unittests	1	0

Additional details and impacted files

@@              Coverage Diff              @@
##               4.20   #12439       +/-   ##
=============================================
- Coverage     16.23%    4.03%   -12.21%     
=============================================
  Files          5657      402     -5255     
  Lines        499024    32701   -466323     
  Branches      60562     5826    -54736     
=============================================
- Hits          81029     1319    -79710     
+ Misses       408959    31227   -377732     
+ Partials       9036      155     -8881     

Flag	Coverage Δ
uitests	4.03% <ø> (ø)
unittests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 16386

[DaanHoogland]

maybe this change causes the unnecessary stubbing error from mockito?

[Pearl1594]

Do you think that the userDataDao.remove(..) performed on L1242 will affect the result of userDataDao.removeByAccountId(..) in other words, do we need it being done twice?

[nvazquez]

As discussed, closing this PR in favour of #11595 @DaanHoogland @shwstppr