Skip to content

Apply suggestions from code review

f4502f1
Select commit
Loading
Failed to load commit list.
Draft

CLVM enhancements and fixes #12617

Apply suggestions from code review
f4502f1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 4, 2026 in 0s

18.23% (+0.21%) compared to 856d83a

View this Pull Request on Codecov

18.23% (+0.21%) compared to 856d83a

Details

Codecov Report

❌ Patch coverage is 43.53920% with 1289 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.23%. Comparing base (856d83a) to head (f4502f1).
⚠️ Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
...oud/hypervisor/kvm/storage/ClvmStorageAdaptor.java 36.26% 436 Missing and 14 partials ⚠️
...ud/hypervisor/kvm/storage/KVMStorageProcessor.java 44.00% 135 Missing and 5 partials ⚠️
...stack/engine/orchestration/VolumeOrchestrator.java 23.46% 73 Missing and 2 partials ⚠️
...n/java/com/cloud/storage/VolumeApiServiceImpl.java 30.52% 62 Missing and 4 partials ⚠️
...ervisor/kvm/resource/LibvirtComputingResource.java 57.04% 53 Missing and 8 partials ⚠️
...resource/wrapper/LibvirtMigrateCommandWrapper.java 13.23% 52 Missing and 7 partials ⚠️
...wrapper/LibvirtClvmLockTransferCommandWrapper.java 37.63% 52 Missing and 6 partials ⚠️
...n/java/com/cloud/vm/VirtualMachineManagerImpl.java 17.85% 46 Missing ⚠️
...n/java/com/cloud/storage/clvm/ClvmPoolManager.java 76.12% 22 Missing and 15 partials ⚠️
...torage/motion/StorageSystemDataMotionStrategy.java 28.57% 35 Missing ⚠️
... and 28 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #12617      +/-   ##
============================================
+ Coverage     18.01%   18.23%   +0.21%     
- Complexity    16607    16952     +345     
============================================
  Files          6029     6045      +16     
  Lines        542154   545626    +3472     
  Branches      66451    67098     +647     
============================================
+ Hits          97681    99484    +1803     
- Misses       433457   435011    +1554     
- Partials      11016    11131     +115     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.