Skip to content

Add per-domain OAuth (Google, GitHub) provider support #12702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Damans227 wants to merge 46 commits into
base: main
Choose a base branch
from

Make strictScope return null when id is null

3b3288c
Select commit
Loading
Failed to load commit list.
Draft

Add per-domain OAuth (Google, GitHub) provider support #12702

Make strictScope return null when id is null
3b3288c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 27, 2026 in 0s

18.02% (+0.10%) compared to 30e6c22

View this Pull Request on Codecov

18.02% (+0.10%) compared to 30e6c22

Details

Codecov Report

❌ Patch coverage is 33.67347% with 130 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.02%. Comparing base (30e6c22) to head (3b3288c).
⚠️ Report is 47 commits behind head on main.

Files with missing lines Patch % Lines
...tack/oauth2/api/command/ListOAuthProvidersCmd.java 0.00% 35 Missing ⚠️
...he/cloudstack/oauth2/dao/OauthProviderDaoImpl.java 0.00% 21 Missing ⚠️
...cloudstack/oauth2/github/GithubOAuth2Provider.java 0.00% 17 Missing ⚠️
...ack/oauth2/api/response/OauthProviderResponse.java 11.76% 14 Missing and 1 partial ⚠️
...th2/api/command/OauthLoginAPIAuthenticatorCmd.java 0.00% 8 Missing ⚠️
...pache/cloudstack/oauth2/OAuth2AuthManagerImpl.java 86.66% 3 Missing and 3 partials ⚠️
...ack/oauth2/api/command/UpdateOAuthProviderCmd.java 0.00% 6 Missing ⚠️
...cloudstack/oauth2/google/GoogleOAuth2Provider.java 70.00% 6 Missing ⚠️
...che/cloudstack/oauth2/OAuth2UserAuthenticator.java 16.66% 4 Missing and 1 partial ⚠️
.../apache/cloudstack/framework/config/ConfigKey.java 0.00% 4 Missing ⚠️
... and 2 more
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #12702      +/-   ##
============================================
+ Coverage     17.92%   18.02%   +0.10%     
- Complexity    16154    16479     +325     
============================================
  Files          5939     5968      +29     
  Lines        533181   537399    +4218     
  Branches      65237    66024     +787     
============================================
+ Hits          95585    96879    +1294     
- Misses       426856   429598    +2742     
- Partials      10740    10922     +182

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov