Skip to content

User vm manager cleanup #12779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
DaanHoogland wants to merge 9 commits into
base: main
Choose a base branch
from
+518 −433

co-pilot's comments addressed

2583d86
Select commit
Loading
Failed to load commit list.
Draft

User vm manager cleanup #12779

co-pilot's comments addressed
2583d86
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed May 6, 2026 in 5m 6s

Quality Gate failed

Failed conditions
9.7% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 474 in server/src/test/java/com/cloud/vm/UserVmManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_virtualNetAppliance" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ3y-YR1Hq9gpljoJRlT&open=AZ3y-YR1Hq9gpljoJRlT&pullRequest=12779

Check failure on line 481 in server/src/test/java/com/cloud/vm/UserVmManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ3y-YR1Hq9gpljoJRlQ&open=AZ3y-YR1Hq9gpljoJRlQ&pullRequest=12779

Check warning on line 2075 in server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 116 to 64, Complexity from 25 to 14, Nesting Level from 5 to 2, Number of Variables from 35 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ3y-X3BHq9gpljoJRlO&open=AZ3y-X3BHq9gpljoJRlO&pullRequest=12779

Check warning on line 1800 in server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 93 to 64, Complexity from 22 to 14, Nesting Level from 5 to 2, Number of Variables from 18 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ33WPXU7ZrcJR12EjLP&open=AZ33WPXU7ZrcJR12EjLP&pullRequest=12779

Check warning on line 7410 in server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 84 to 64, Complexity from 28 to 14, Nesting Level from 5 to 2, Number of Variables from 23 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ33WPXU7ZrcJR12EjLQ&open=AZ33WPXU7ZrcJR12EjLQ&pullRequest=12779

Check warning on line 2807 in server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Invoke method(s) only conditionally. Use the built-in formatting to construct this argument. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ33WPXU7ZrcJR12EjLL&open=AZ33WPXU7ZrcJR12EjLL&pullRequest=12779

Check warning on line 9608 in server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 132 to 64, Complexity from 31 to 14, Nesting Level from 3 to 2, Number of Variables from 33 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ33WPXU7ZrcJR12EjLR&open=AZ33WPXU7ZrcJR12EjLR&pullRequest=12779

Check warning on line 4807 in server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 111 to 64, Complexity from 29 to 14, Nesting Level from 3 to 2, Number of Variables from 56 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ33WPXU7ZrcJR12EjLT&open=AZ33WPXU7ZrcJR12EjLT&pullRequest=12779

Check warning on line 1214 in server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Return an empty map instead of null. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ3y-X3BHq9gpljoJRkp&open=AZ3y-X3BHq9gpljoJRkp&pullRequest=12779

Check failure on line 6350 in server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 30 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ3y-X3BHq9gpljoJRlB&open=AZ3y-X3BHq9gpljoJRlB&pullRequest=12779

Check warning on line 468 in server/src/test/java/com/cloud/vm/UserVmManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_vmNetworkMapDao" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ3y-YR1Hq9gpljoJRlR&open=AZ3y-YR1Hq9gpljoJRlR&pullRequest=12779

Check warning on line 9193 in server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 65 to 64, Complexity from 17 to 14, Nesting Level from 6 to 2, Number of Variables from 15 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ33WPXU7ZrcJR12EjLS&open=AZ33WPXU7ZrcJR12EjLS&pullRequest=12779

Check warning on line 2907 in server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 130 to 64, Complexity from 50 to 14, Nesting Level from 5 to 2, Number of Variables from 35 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ3y-X3BHq9gpljoJRlN&open=AZ3y-X3BHq9gpljoJRlN&pullRequest=12779

Check warning on line 8990 in server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a primitive boolean expression here. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ3y-X3BHq9gpljoJRkn&open=AZ3y-X3BHq9gpljoJRkn&pullRequest=12779

Check warning on line 5488 in server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 98 to 64, Complexity from 23 to 14, Nesting Level from 5 to 2, Number of Variables from 31 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ3y-X3BHq9gpljoJRlP&open=AZ3y-X3BHq9gpljoJRlP&pullRequest=12779

Check warning on line 5612 in server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a primitive boolean expression here. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ3y-X3BHq9gpljoJRkm&open=AZ3y-X3BHq9gpljoJRkm&pullRequest=12779

Check warning on line 8113 in server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Method has 8 parameters, which is greater than 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ3y-X3BHq9gpljoJRko&open=AZ3y-X3BHq9gpljoJRko&pullRequest=12779

Check warning on line 471 in server/src/test/java/com/cloud/vm/UserVmManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_routerDao" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ3y-YR1Hq9gpljoJRlS&open=AZ3y-YR1Hq9gpljoJRlS&pullRequest=12779
View more details on SonarQubeCloud