Skip to content

[CI] Create .codespellrc; upgrade codespell hook; fix typos#12824

Merged
DaanHoogland merged 3 commits intoapache:mainfrom
jbampton:add-codespellrc
Mar 31, 2026
Merged

[CI] Create .codespellrc; upgrade codespell hook; fix typos#12824
DaanHoogland merged 3 commits intoapache:mainfrom
jbampton:add-codespellrc

Conversation

@jbampton
Copy link
Copy Markdown
Member

Description

This PR creates a centralized codespell config.

Some of the benefits of having a separate small .codespellrc will be that less technical contributors will easily see the config file in the repo root and will be able to fix typos.

The new config points users to the ignored words list and shows how to skip files and directories.

Basically this means they won't have to touch the pre-commit config file

This PR upgraded the codespell hook and then fixed some minor typos that the new version of codespell found.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Ran pre-commit run --all-files

How did you try to break this feature and the system with this change?

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 17, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 18.01%. Comparing base (18075ae) to head (70e156d).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
.../main/java/com/cloud/utils/db/SequenceFetcher.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #12824      +/-   ##
============================================
- Coverage     18.01%   18.01%   -0.01%     
- Complexity    16459    16463       +4     
============================================
  Files          5968     5973       +5     
  Lines        537218   537466     +248     
  Branches      65977    65991      +14     
============================================
+ Hits          96801    96845      +44     
- Misses       429498   429699     +201     
- Partials      10919    10922       +3     
Flag Coverage Δ
uitests 3.52% <ø> (-0.01%) ⬇️
unittests 19.18% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jbampton jbampton requested a review from vishesh92 March 17, 2026 10:07
@DaanHoogland
Copy link
Copy Markdown
Contributor

@vishesh92 can you merge (if you agree)?

@jbampton
Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

Copy link
Copy Markdown
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@blueorangutan
Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17305

@DaanHoogland
Copy link
Copy Markdown
Contributor

just comments and log messages touched; merging

@DaanHoogland DaanHoogland merged commit 5d61ba3 into apache:main Mar 31, 2026
25 of 28 checks passed
@DaanHoogland DaanHoogland added this to the 4.23.0 milestone Mar 31, 2026
@jbampton jbampton deleted the add-codespellrc branch March 31, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants