Skip to content

Fix NSX SDK list handling to fetch all paginated results #12834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sureshanaparti merged 1 commit into from
Apr 16, 2026

fix: NSX SDK list operations are pageable: the API returns a non-null…

8d70de6
Select commit
Loading
Failed to load commit list.
Merged

Fix NSX SDK list handling to fetch all paginated results #12834

fix: NSX SDK list operations are pageable: the API returns a non-null…
8d70de6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 15, 2026 in 1s

17.95% (+0.34%) compared to 23f633a

View this Pull Request on Codecov

17.95% (+0.34%) compared to 23f633a

Details

Codecov Report

❌ Patch coverage is 25.85034% with 109 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.95%. Comparing base (23f633a) to head (8d70de6).
⚠️ Report is 7 commits behind head on 4.22.

Files with missing lines Patch % Lines
...va/org/apache/cloudstack/service/NsxApiClient.java 0.00% 106 Missing ⚠️
...va/org/apache/cloudstack/service/PagedFetcher.java 92.68% 0 Missing and 3 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               4.22   #12834      +/-   ##
============================================
+ Coverage     17.61%   17.95%   +0.34%     
- Complexity    15706    16531     +825     
============================================
  Files          5921     6023     +102     
  Lines        532392   541495    +9103     
  Branches      65109    66352    +1243     
============================================
+ Hits          93788    97238    +3450     
- Misses       428015   433287    +5272     
- Partials      10589    10970     +381

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov