Skip to content

fix setting param in dao

12d61e3
Select commit
Loading
Failed to load commit list.
Merged

Prevent deletion of account and domain if either of them has deleted protected instance #12901

fix setting param in dao
12d61e3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 2, 2026 in 1s

17.60% (-0.01%) compared to c1af36f, passed because coverage increased by 0% when compared to adjusted base (17.61%)

View this Pull Request on Codecov

17.60% (-0.01%) compared to c1af36f, passed because coverage increased by 0% when compared to adjusted base (17.61%)

Details

Codecov Report

❌ Patch coverage is 28.30189% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.60%. Comparing base (c1af36f) to head (12d61e3).
⚠️ Report is 9 commits behind head on 4.22.

Files with missing lines Patch % Lines
.../main/java/com/cloud/vm/dao/VMInstanceDaoImpl.java 0.00% 24 Missing ⚠️
...c/main/java/com/cloud/user/AccountManagerImpl.java 46.15% 6 Missing and 1 partial ⚠️
...rc/main/java/com/cloud/user/DomainManagerImpl.java 56.25% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               4.22   #12901      +/-   ##
============================================
- Coverage     17.61%   17.60%   -0.01%     
- Complexity    15676    15679       +3     
============================================
  Files          5917     5918       +1     
  Lines        531537   531732     +195     
  Branches      64985    65009      +24     
============================================
+ Hits          93610    93635      +25     
- Misses       427369   427534     +165     
- Partials      10558    10563       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.