Skip to content

Revert "Use lateral join (introduced in MySQL 8.0.14) with subquery on user_statistics table in account_view for netstats"#12965

Open
sureshanaparti wants to merge 1 commit into4.22from
revert-lateral-join-change
Open

Revert "Use lateral join (introduced in MySQL 8.0.14) with subquery on user_statistics table in account_view for netstats"#12965
sureshanaparti wants to merge 1 commit into4.22from
revert-lateral-join-change

Conversation

@sureshanaparti
Copy link
Copy Markdown
Contributor

Description

This PR reverts "Use lateral join (introduced in MySQL 8.0.14) with subquery on user_statistics table in account_view for netstats (#12631)", commit 58916eb.

Lateral Join is not supported in MariaDB yet. Ref: https://jira.mariadb.org/browse/MDEV-19078

Fixes #12907

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

…n user_statistics table in account_view for netstats (#12631)"

This reverts commit 58916eb.
@sureshanaparti
Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.60%. Comparing base (4708121) to head (a056909).

Additional details and impacted files
@@             Coverage Diff              @@
##               4.22   #12965      +/-   ##
============================================
- Coverage     17.60%   17.60%   -0.01%     
+ Complexity    15677    15676       -1     
============================================
  Files          5918     5918              
  Lines        531681   531681              
  Branches      65005    65005              
============================================
- Hits          93623    93616       -7     
- Misses       427498   427505       +7     
  Partials      10560    10560              
Flag Coverage Δ
uitests 3.70% <ø> (ø)
unittests 18.67% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link
Copy Markdown

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 6, 2026

@blueorangutan
Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17364

@sureshanaparti
Copy link
Copy Markdown
Contributor Author

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

[SF] Trillian test result (tid-15816)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 49955 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12965-t15816-kvm-ol8.zip
Smoke tests completed. 148 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL Failure 283.01 test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics Failure 377.37 test_vpc_redundant.py

Copy link
Copy Markdown
Contributor

@gp-santos gp-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The errors were gone and I was able to finish setting up the environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

Account view's lateral join not supported in MariaDB

5 participants