Add support to update secondary and primary storage URLs#13193
Add support to update secondary and primary storage URLs#13193Pearl1594 wants to merge 2 commits into
Conversation
|
@DaanHoogland do you think we need to expose updating this via UI or leave this as a API only field? I feel it could be a bit of a dangerous operation should it be used incorrectly. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #13193 +/- ##
============================================
+ Coverage 18.08% 18.09% +0.01%
- Complexity 16718 16742 +24
============================================
Files 6037 6037
Lines 542580 542818 +238
Branches 66427 66500 +73
============================================
+ Hits 98136 98241 +105
- Misses 433417 433547 +130
- Partials 11027 11030 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I agree, let limit to API |
…he hosts only for nfs and gluster
|


Description
This PR fixes: #11742
Adds support to update the URL of primary and secondary stores. However, the support is limited to API and not extended to the UI as this is an operation that if performed without caution can lead to issues - data loss.
Secondary store:
The store needs to be in read-only mode before attempting to change the url.
Secondary storage VM needs to be recreated to remount the new store
Primary store:
The primary store needs to be in Maintenance mode to proceed with updating the URL
The update of URL was previously purely cosmetic / informational ie updated in the database - details table. This continues to be true for storage pools other than nfs and gluster
For NFS and Gluster, if the URL is changed, it propagates it to the connected hosts and attempts to remove the old store and add the new one
In case , no hosts are found, it only changes the URL in the DB and this would require a MS restart to propagate to the host.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?