Fix Static NAT/Port Forwarding when VM NIC is not the default#13200
Draft
sudo87 wants to merge 1 commit into
Draft
Fix Static NAT/Port Forwarding when VM NIC is not the default#13200sudo87 wants to merge 1 commit into
sudo87 wants to merge 1 commit into
Conversation
boring-cyborg
Bot
added
component:networking
component:virtual-router
Python
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13200 +/- ##
=========================================
Coverage 18.08% 18.08%
Complexity 16718 16718
=========================================
Files 6037 6037
Lines 542611 542611
Branches 66433 66433
=========================================
Hits 98136 98136
Misses 433448 433448
Partials 11027 11027
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| if internal_device and internal_vr_ip and internal_device != device: | ||
| self.fw.append(["nat", "front", | ||
| "-A POSTROUTING -o %s -d %s/32 -j SNAT --to-source %s" % | ||
| (internal_device, rule["internal_ip"], internal_vr_ip)]) |
Member
There was a problem hiding this comment.
- this should apply to additional nics of guest VMs only. since there is no issue with first NIC of guest VMs, it is not needed.
- it would be better to provide an option for end users.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR intends to fix #8366
When CloudStack VR forwards traffic to a VM whose NIC is not the VM's default, the VM may reply via its default NIC (asymmetric routing). To force symmetric routing we SNAT the forwarded packet's source to the VR’s guest IP on the VM subnet so the VM replies on-link back to that VR interface. Also fix the port-forwarding SNAT to pick the correct VR guest IP for the VM's subnet
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?