Skip to content

Change configs 'consoleproxy.management.state' and 'consoleproxy.management.state.last' to dynamic and some improvements in Console Proxy Manager#13202

Open
sureshanaparti wants to merge 1 commit into
apache:4.22from
shapeblue:console-proxy-manager-improvements
Open

Change configs 'consoleproxy.management.state' and 'consoleproxy.management.state.last' to dynamic and some improvements in Console Proxy Manager#13202
sureshanaparti wants to merge 1 commit into
apache:4.22from
shapeblue:console-proxy-manager-improvements

Conversation

@sureshanaparti
Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti commented May 20, 2026

Description

This PR changes the configurations 'consoleproxy.management.state' and 'consoleproxy.management.state.last' to dynamic, add few logs, and has some improvements in Console Proxy Manager.

The configurations 'consoleproxy.management.state' and 'consoleproxy.management.state.last' were updated in the runtime, and Console Proxy Manager is not able to access the updated values as these configurations are marked as not dynamic here , previously the values were directly accessed from the configuration table using the dao, which was changed here: https://github.com/apache/cloudstack/pull/11415/changes#diff-83d8d4dd27757aa0ff1364c3d156e2396e79f043073acffdddfeb37b1790a8c7.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@sureshanaparti sureshanaparti changed the title Console Proxy Manager code improvements Change configs 'consoleproxy.management.state' and 'consoleproxy.management.state.last' to dynamic and some improvements in Console Proxy Manager May 20, 2026
…gement.state.last' to dynamic and some improvements in Console Proxy Manager
@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

❌ Patch coverage is 9.37500% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.67%. Comparing base (35ac91e) to head (aac7a56).

Files with missing lines Patch % Lines
...om/cloud/consoleproxy/ConsoleProxyManagerImpl.java 0.00% 26 Missing ⚠️
...udstack/framework/config/impl/ConfigurationVO.java 0.00% 0 Missing and 2 partials ⚠️
...in/java/com/cloud/server/ManagementServerImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               4.22   #13202      +/-   ##
============================================
- Coverage     17.67%   17.67%   -0.01%     
  Complexity    15788    15788              
============================================
  Files          5922     5922              
  Lines        533121   533125       +4     
  Branches      65201    65201              
============================================
  Hits          94240    94240              
- Misses       428236   428240       +4     
  Partials      10645    10645              
Flag Coverage Δ
uitests 3.69% <ø> (ø)
unittests 18.75% <9.37%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sureshanaparti sureshanaparti force-pushed the console-proxy-manager-improvements branch from 64cc338 to aac7a56 Compare May 20, 2026 19:21
@sureshanaparti
Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@sureshanaparti sureshanaparti added this to the 4.22.2 milestone May 20, 2026
@blueorangutan
Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17945

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants