Skip to content

UI Storage Pool Tags: unable to delete last tag #4611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yadvr merged 2 commits into from
Jan 25, 2021
Merged

UI Storage Pool Tags: unable to delete last tag #4611

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d971036
UI Storage Pool Tags: unable to delete last tag
Jan 22, 2021
c49068d
add updatePhysicalNetwork to the list
Jan 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ui/src/views/AutogenView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -957,7 +957,8 @@ export default {
if (param.name !== key) {
continue
}
if (input === undefined || input === null || input === '') {
if (input === undefined || input === null || (input === '' &&
Comment thread
utchoang marked this conversation as resolved.
Outdated
!['updateStoragePool', 'updateHost'].includes(action.api))) {

@harikrishna-patnala harikrishna-patnala Jan 25, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pearl1594 we have physical networks tags also, I just checked we could not delete the tag on physical network too, can you please add that here.

if (param.type === 'boolean') {
params[key] = false
}
Expand Down