[Vmware] Fix worker VMs hardware version small bug

[nvazquez]

Description

This PR fixes a small bug when explicitly setting VM hardware versions lower than version 10.

Vmware expects the hardware version in format: vmx-DD where DD is a two-digit representation of the virtual hardware version. For hardware version lower than 10, CloudStack was not using to digits for the hardware version number, which ended up on an error while creating worker VMs. (vmx-8 for example instead of vmx-08)

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

[nvazquez]

@blueorangutan package

[blueorangutan]

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]

[blueorangutan]

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 195

[nvazquez]

@blueorangutan test centos7 vmware-67u3

[blueorangutan]

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests [S]

[yadvr]

@nvazquez all bug fixes should go to 4.15, I've changed base/branch against 4.15.
@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 197

[yadvr]

@blueorangutan test centos7 vmware-67u3

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

[nvazquez]

@blueorangutan package

[nvazquez]

Rebased 4.15 and added unit tests - @rhtyd @sureshanaparti @DaanHoogland can you please review?

[nvazquez]

@blueorangutan package

[blueorangutan]

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 204

[nvazquez]

@blueorangutan test centos7 vmware67-u3

[blueorangutan]

@nvazquez unsupported parameters provided. Supported mgmt server os are: centos6, centos7, centos8, ubuntu. Supported hypervisors are: kvm-centos6, kvm-centos7, kvm-centos8, kvm-ubuntu, xenserver-71, xenserver-65sp1, vmware-67u3, vmware-65u2, vmware-60u2, vmware-55u3, xcpng76, xcpng80, xcpng81, xenserver-74, xcpng74

[nvazquez]

@blueorangutan test centos7 vmware-67u3

[blueorangutan]

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

[sureshanaparti]

code LGTM

[blueorangutan]

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 240

[blueorangutan]

Trillian test result (tid-256)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40738 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4851-t256-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 82 look OK, 4 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_DeployVmAntiAffinityGroup_in_project	Error	64.04	test_affinity_groups_projects.py
test_DeployVmAntiAffinityGroup	Error	36.41	test_affinity_groups.py
test_04_deploy_and_scale_kubernetes_cluster	Failure	26.67	test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster	Failure	0.04	test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster	Failure	0.04	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	Failure	0.03	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	Error	34.20	test_kubernetes_clusters.py
test_disable_oobm_ha_state_ineligible	Error	1512.37	test_hostha_kvm.py

[yadvr]

@DaanHoogland are you lgtm on this?
@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔️ centos7 ✔️ centos8 ✖️ debian. SL-JID 314

[yadvr]

@blueorangutan test

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-349)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36168 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4851-t349-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Smoke tests completed. 84 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestKubernetesCluster>:teardown	Error	74.07	test_kubernetes_clusters.py
test_01_migrate_VM_and_root_volume	Error	69.26	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	Error	48.04	test_vm_life_cycle.py

[DaanHoogland]

@DaanHoogland are you lgtm on this?

I am @rhtyd , awaiting @andrijapanicsb 's thoughts though

[DaanHoogland]

tested on older versions, looks good

[andrijapanicsb]

LGTM, merge it.