UI: fix login on UI#4910
Merged
Merged
Conversation
Contributor
Author
|
@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
shwstppr
approved these changes
Apr 12, 2021
Contributor
|
@blueorangutan package |
|
@alexandremattioli a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 394 |
yadvr
approved these changes
Apr 12, 2021
yadvr
reviewed
Apr 12, 2021
| const params = new URLSearchParams() | ||
| params.append('command', 'login') | ||
| params.append('username', arg.username) | ||
| params.append('username', arg.username || arg.email) |
Member
There was a problem hiding this comment.
The culprit is in Login.vue, but this is okay.
Member
There was a problem hiding this comment.
Member
|
Tested LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4908
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Specify username in the following format : xxx@domain.com and verified the login parameters being passed. Username is no longer undefined but points to the passed email address.
Without fix:
With Fix:
