Skip to content

Support to update disk/network offering tags from UI#4923

Merged
yadvr merged 1 commit into
apache:4.15from
slavkap:fix_ui_tags
Apr 16, 2021
Merged

Support to update disk/network offering tags from UI#4923
yadvr merged 1 commit into
apache:4.15from
slavkap:fix_ui_tags

Conversation

@slavkap

@slavkap slavkap commented Apr 15, 2021

Copy link
Copy Markdown
Contributor

Description

added support to update tags of disk and network offerings from UI
fix for delete the last tag

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

How Has This Been Tested?

manually tested

added support to update tags of disk and network offerings from UI
fix deletion of the last tag

@yadvr yadvr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - did n't test it

@yadvr yadvr added this to the 4.15.1.0 milestone Apr 15, 2021
@yadvr

yadvr commented Apr 15, 2021

Copy link
Copy Markdown
Member

Please review/test @Pearl1594 @shwstppr @davidjumani @Spaceman1984

Comment thread ui/src/views/AutogenView.vue

@shwstppr shwstppr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. LGTM

@shwstppr

Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4923 (SL-JID-99)

@Pearl1594 Pearl1594 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified. LGTM

@yadvr yadvr merged commit 0bbf114 into apache:4.15 Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants