Skip to content

Improve global settings UI to be more intuitive/logical#5797

Merged
DaanHoogland merged 36 commits intoapache:mainfrom
shapeblue:global-settings-intuitive-ui
Jan 31, 2023
Merged

Improve global settings UI to be more intuitive/logical#5797
DaanHoogland merged 36 commits intoapache:mainfrom
shapeblue:global-settings-intuitive-ui

Conversation

@sureshanaparti
Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti commented Dec 21, 2021

Description

This PR improve global settings UI to be more intuitive/logical.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

Screenshot from 2023-01-05 16-16-29
Screenshot from 2023-01-05 16-18-22

@sureshanaparti sureshanaparti force-pushed the global-settings-intuitive-ui branch 7 times, most recently from 6689f01 to 5f25960 Compare January 5, 2022 12:19
@yadvr yadvr added this to the 4.17.0.0 milestone Feb 4, 2022
@nvazquez
Copy link
Copy Markdown
Contributor

nvazquez commented Feb 6, 2022

@sureshanaparti is this PR still in progress?

@sureshanaparti
Copy link
Copy Markdown
Contributor Author

@sureshanaparti is this PR still in progress?

yes @nvazquez, work in progress.

@sureshanaparti sureshanaparti changed the title Improve global settings UI to be more intuitive/logical [WIP] Improve global settings UI to be more intuitive/logical Feb 7, 2022
@nvazquez
Copy link
Copy Markdown
Contributor

nvazquez commented Mar 2, 2022

@sureshanaparti can you please fix the conflicts?

@sureshanaparti sureshanaparti self-assigned this Mar 23, 2022
@sureshanaparti sureshanaparti force-pushed the global-settings-intuitive-ui branch 2 times, most recently from 789378b to c51830a Compare March 25, 2022 08:30
@sureshanaparti
Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@sureshanaparti a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2984

@nvazquez
Copy link
Copy Markdown
Contributor

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

Trillian test result (tid-3720)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33638 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5797-t3720-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

@sureshanaparti
Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@sureshanaparti a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@sureshanaparti sureshanaparti force-pushed the global-settings-intuitive-ui branch from 67194e9 to e54e071 Compare March 29, 2022 08:21
@apache apache deleted a comment from blueorangutan Mar 29, 2022
@sureshanaparti
Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@sureshanaparti a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3005

@github-actions
Copy link
Copy Markdown

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@DaanHoogland
Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 5336

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✖️ el7 ✔️ debian. SL-JID 5343

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5350

@DaanHoogland
Copy link
Copy Markdown
Contributor

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

Trillian test result (tid-5927)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40954 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5797-t5927-kvm-centos7.zip
Smoke tests completed. 107 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@github-actions
Copy link
Copy Markdown

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@DaanHoogland
Copy link
Copy Markdown
Contributor

@davidjumani can you have a look at this conflict?

@davidjumani
Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@davidjumani a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5374

@davidjumani
Copy link
Copy Markdown
Contributor

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

Trillian test result (tid-5958)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 51257 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5797-t5958-kvm-centos7.zip
Smoke tests completed. 106 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_disable_oobm_ha_state_ineligible Error 1513.09 test_hostha_kvm.py
test_hostha_kvm_host_degraded Error 7.25 test_hostha_kvm.py

@davidjumani
Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@davidjumani a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5438

@sonarqubecloud
Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 56 Code Smells

19.0% 19.0% Coverage
2.5% 2.5% Duplication

@davidjumani
Copy link
Copy Markdown
Contributor

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

Trillian test result (tid-6030)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41092 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5797-t6030-kvm-centos7.zip
Smoke tests completed. 107 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

Copy link
Copy Markdown
Contributor

@andrijapanicsb andrijapanicsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, after manual testing and review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.