Validate host tags on VM live scale

[BryanMLima]

Description

Currently, ACS does not validate host tags on running VMs that have their computing resources increased via Scale VM command. Therefore, if a service offering with host tags deploys on a host with the same host tags, it is permitted to live scale this VM to another service offering with another host tags. This PR aims to fix this bug, verifying the host tags on a VM live scaling.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

This was tested in a local lab with the following scenario:

1. VM deployed with a service offering with host tags hdd.
2. Tried to live scale the VM with another service offering with host tags ssd.
3. An error occurred while scaling the VM, as expected.

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[GutoVeronezi]

CLGTM

[GutoVeronezi]

@blueorangutan package

[blueorangutan]

@GutoVeronezi a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✖️ suse15. SL-JID 3618

[sureshanaparti]

@blueorangutan test

[blueorangutan]

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-4351)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36722 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6409-t4351-kvm-centos7.zip
Smoke tests completed. 98 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

[JoaoJandre]

CLGTM

[RodrigoDLopez]

clgtm

[BryanMLima]

@DaanHoogland @GutoVeronezi Could you take another look on this one? I think this PR is already good to merge.

[DaanHoogland]

trusting the developers tests on this one

[yadvr]

cc @DaanHoogland milestone missing

[yadvr]

Also manual tests if any required missing cc @shwstppr @harikrishna-patnala