Fixed Veeam listing restore points

[harikrishna-patnala]

Description

This PR fixes the issue #6465 where listing backup restore points are failing with Veeam version v11.0.1.1261.

Though this version is not fully supported for backup and recovery, existing backups, restore points for the VMs can continue to work with the Veeam version v11.0.1.1261. I've created a separate ticket here to fully support the version #6554

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

1. Setup Veeam v11.0.1.1261 with CloudStack
2. Added a back offering to the volume
3. Created a backup to the VM
4. Wait for the back sync to trigger in CloudStack
5. Restore points listed and saved in the database in the table "backups"

[acs-robot]

Found UI changes, kicking a new UI QA build
@blueorangutan ui

[blueorangutan]

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[harikrishna-patnala]

@blueorangutan package

[blueorangutan]

@harikrishna-patnala a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[acs-robot]

Found UI changes, kicking a new UI QA build
@blueorangutan ui

[blueorangutan]

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6555 (SL-JID-1973)

[harikrishna-patnala]

@blueorangutan package

[blueorangutan]

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6555 (SL-JID-1974)

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3785

[acs-robot]

Found UI changes, kicking a new UI QA build
@blueorangutan ui

[blueorangutan]

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6555 (SL-JID-1979)

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[yadvr]

LGTM but really needs testing against the said version of support veeam B&R

[shwstppr]

@harikrishna-patnala should this be fixed in 4.17 branch?

[harikrishna-patnala]

No need I think @shwstppr because this is more related to the latest version of Veeam which we don't fully support. We have created a separate ticket for that too #6554

[harikrishna-patnala]

@SadiJr Can you please help me test this PR with the Veeam version v11.0.1.1261 ?

Though this version is not fully supported from a fresh install, it will still work with older version and even after upgrading to the v11.0.1.1261. You can also try any test environment if you have by upgrading it to this version v11.0.1.1261. Thanks in advance.

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3943

[yadvr]

@blueorangutan test

[blueorangutan]

@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-4663)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44995 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6555-t4663-kvm-centos7.zip
Smoke tests completed. 100 look OK, 1 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_08_upgrade_kubernetes_ha_cluster	Failure	3644.57	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	Failure	0.05	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	Error	68.73	test_kubernetes_clusters.py

[shwstppr]

Test failures are unrelated, merging based on approvals and testing

[SadiJr]

@harikrishna-patnala sorry for the delay in answer. I tested in my lab with the Veeam build 11.0.1.1261 P20211211, comparing with the main commit bca6076, and the error reported in issue #6465 is fixed. About issue #6554, I cannot reproduce the second example; can you please inform your version of Windows and PowerShell?