Skip to content

Fixed Veeam listing restore points#6555

Merged
shwstppr merged 2 commits intoapache:mainfrom
shapeblue:FixedVeeamListingRestorePoints
Aug 10, 2022
Merged

Fixed Veeam listing restore points#6555
shwstppr merged 2 commits intoapache:mainfrom
shapeblue:FixedVeeamListingRestorePoints

Conversation

@harikrishna-patnala
Copy link
Copy Markdown
Member

@harikrishna-patnala harikrishna-patnala commented Jul 18, 2022 •
edited
Loading

Description

This PR fixes the issue #6465 where listing backup restore points are failing with Veeam version v11.0.1.1261.

Though this version is not fully supported for backup and recovery, existing backups, restore points for the VMs can continue to work with the Veeam version v11.0.1.1261. I've created a separate ticket here to fully support the version #6554

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

image

How Has This Been Tested?

  1. Setup Veeam v11.0.1.1261 with CloudStack
  2. Added a back offering to the volume
  3. Created a backup to the VM
  4. Wait for the back sync to trigger in CloudStack
  5. Restore points listed and saved in the database in the table "backups"

@acs-robot
Copy link
Copy Markdown

acs-robot commented Jul 18, 2022

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 18, 2022

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@harikrishna-patnala harikrishna-patnala force-pushed the FixedVeeamListingRestorePoints branch from b3bc1b4 to d34a05a Compare July 18, 2022 12:37
@harikrishna-patnala
Copy link
Copy Markdown
Member Author

harikrishna-patnala commented Jul 18, 2022

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 18, 2022

@harikrishna-patnala a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@acs-robot
Copy link
Copy Markdown

acs-robot commented Jul 18, 2022

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 18, 2022

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 18, 2022

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6555 (SL-JID-1973)

@harikrishna-patnala harikrishna-patnala force-pushed the FixedVeeamListingRestorePoints branch from d34a05a to 4ceb76f Compare July 18, 2022 12:43
@harikrishna-patnala
Copy link
Copy Markdown
Member Author

harikrishna-patnala commented Jul 18, 2022

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 18, 2022

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6555 (SL-JID-1974)

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 18, 2022

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3785

@acs-robot
Copy link
Copy Markdown

acs-robot commented Jul 19, 2022

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 19, 2022

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 19, 2022

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6555 (SL-JID-1979)

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jul 19, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

yadvr
yadvr approved these changes Jul 20, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@yadvr yadvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but really needs testing against the said version of support veeam B&R

@yadvr yadvr added this to the 4.18.0.0 milestone Jul 20, 2022
@shwstppr
Copy link
Copy Markdown
Contributor

shwstppr commented Jul 25, 2022

@harikrishna-patnala should this be fixed in 4.17 branch?

@yadvr yadvr requested a review from shwstppr July 25, 2022 07:33
@harikrishna-patnala
Copy link
Copy Markdown
Member Author

harikrishna-patnala commented Jul 25, 2022

No need I think @shwstppr because this is more related to the latest version of Veeam which we don't fully support. We have created a separate ticket for that too #6554

@harikrishna-patnala
Copy link
Copy Markdown
Member Author

harikrishna-patnala commented Jul 26, 2022

@SadiJr Can you please help me test this PR with the Veeam version v11.0.1.1261 ?

Though this version is not fully supported from a fresh install, it will still work with older version and even after upgrading to the v11.0.1.1261. You can also try any test environment if you have by upgrading it to this version v11.0.1.1261. Thanks in advance.

@shwstppr
Copy link
Copy Markdown
Contributor

shwstppr commented Aug 9, 2022

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 9, 2022

@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 9, 2022

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3943

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Aug 9, 2022

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 9, 2022

@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 9, 2022

Trillian test result (tid-4663)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44995 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6555-t4663-kvm-centos7.zip
Smoke tests completed. 100 look OK, 1 have errors
Only failed tests results shown below:

Test Result Time (s) Test File
test_08_upgrade_kubernetes_ha_cluster Failure 3644.57 test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster Failure 0.05 test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown Error 68.73 test_kubernetes_clusters.py

@shwstppr
Copy link
Copy Markdown
Contributor

shwstppr commented Aug 10, 2022

Test failures are unrelated, merging based on approvals and testing

@shwstppr shwstppr merged commit d3ec27d into apache:main Aug 10, 2022
@SadiJr
Copy link
Copy Markdown
Contributor

SadiJr commented Aug 10, 2022

@harikrishna-patnala sorry for the delay in answer. I tested in my lab with the Veeam build 11.0.1.1261 P20211211, comparing with the main commit bca6076, and the error reported in issue #6465 is fixed. About issue #6554, I cannot reproduce the second example; can you please inform your version of Windows and PowerShell?

@yadvr yadvr mentioned this pull request Aug 16, 2022
Closed
neogismm pushed a commit to neogismm/cloudstack that referenced this pull request Sep 5, 2022
@harikrishna-patnala @neogismm
Fixed Veeam listing restore points (apache#6555)
834447b 
Fixes issue apache#6465 where listing backup restore points are failing with Veeam version v11.0.1.1261.

Though this version is not fully supported for backup and recovery, existing backups, restore points for the VMs can continue to work with the Veeam version v11.0.1.1261. I've created a separate ticket here to fully support the version apache#6554
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@shwstppr shwstppr shwstppr approved these changes

@Pearl1594 Pearl1594 Awaiting requested review from Pearl1594

Assignees

No one assigned

Labels

component:api component:backup component:integration-test component:ipv6 component:marvin component:UI Python Warning... Python code Ahead!

Projects

None yet

Milestone

4.18.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@harikrishna-patnala @acs-robot @blueorangutan @shwstppr @yadvr @SadiJr