Skip to content

Scope setting changes in ldap and utils pom.xml files#6557

Merged
yadvr merged 1 commit intoapache:mainfrom
shapeblue:DependencyScopeChanges
Jul 20, 2022
Merged

Scope setting changes in ldap and utils pom.xml files#6557
yadvr merged 1 commit intoapache:mainfrom
shapeblue:DependencyScopeChanges

Conversation

@harikrishna-patnala
Copy link
Copy Markdown
Member

@harikrishna-patnala harikrishna-patnala commented Jul 19, 2022

Description

This PR fixes the issue #6259.
We have changed the scope of the artifacts embedded-ldap-junit and commons-io as appropriate.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@harikrishna-patnala
Copy link
Copy Markdown
Member Author

@blueorangutan package

@acs-robot
Copy link
Copy Markdown

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6557 (SL-JID-1981)

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Copy Markdown
Member

@yadvr yadvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if build passes

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Jul 20, 2022

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with

SystemVM template(s). I'll keep you posted as I make progress.

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Jul 20, 2022

@harikrishna-patnala do we also need to check the suggestion:

in server\pom.xml, mysql:mysql-connector-java scope should be compile instead of test.

@harikrishna-patnala
Copy link
Copy Markdown
Member Author

@harikrishna-patnala do we also need to check the suggestion:

in server\pom.xml, mysql:mysql-connector-java scope should be compile instead of test.

This is already at default scope "compile"

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3794

Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yadvr yadvr added this to the 4.18.0.0 milestone Jul 20, 2022
@yadvr yadvr merged commit d4460a8 into apache:main Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants