scripts: parametrize systemvm, router restart by shwstppr · Pull Request #6574 · apache/cloudstack

shwstppr · 2022-07-27T10:57:11Z

Description

Fixes #6220

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

[root@ref-trl-3339-v-M7-abhishek-kumar-mgmt1 ~]# /usr/bin/cloudstack-sysvmadm

The tool stopping/starting running system vms and domain routers 

Usage: cloudstack-sysvmadm: [-d] [-u] [-p] [-m] [-s] [-r] [-a] [-t] [-n] [-z] [-i] [-j] [-v] [-i] [-j]

 -d - cloud DB server ip address, defaulted to localhost if not specified 
 -u - user name to access cloud DB, defaulted to root if not specified 
 -p - cloud DB user password, defaulted to no password if not specified 

 -m - the ip address of management server, defaulted to localhost if not specified

 -s - stop then start all running SSVMs and Console Proxies 
 -r - stop then start all running Virtual Routers
 -a - stop then start all running SSVMs, Console Proxies, and Virtual Routers 
 -n - restart all Guest networks 
 -t - number of parallel threads used for stopping Domain Routers. Default is 10.
 -l - log file location. Default is cloud.log under current directory.
 -z - do restart only for the instances in the specific zone. If not specified, restart will apply to instances in all zones
 -v - do restart all VPCs in the entire system
 -i - do restart on instances with specific IDs. Comma-separated instance IDs to be provided. Works ony when restarting SSVMs, CPVMs or VRs
 -j - do restart on instances from the specified database table. If not specified, restart will apply on instances present in cloud.vm_instance database table. Works ony when restarting SSVMs, CPVMs or VRs
[root@ref-trl-3339-v-M7-abhishek-kumar-mgmt1 ~]# /usr/bin/cloudstack-sysvmadm -a -u root -p P@ssword123 -i 9b802cd9-8d97-42dc-9610-2650a2831fee,2f1d6bc1-7143-42b7-a5b7-2383d4eddcb9

Stopping and starting 1 secondary storage vm(s) with id=9b802cd9-8d97-42dc-9610-2650a2831fee,2f1d6bc1-7143-42b7-a5b7-2383d4eddcb9...
Done stopping and starting secondary storage vm(s) with id=9b802cd9-8d97-42dc-9610-2650a2831fee,2f1d6bc1-7143-42b7-a5b7-2383d4eddcb9

Stopping and starting 1 console proxy vm(s) with id=9b802cd9-8d97-42dc-9610-2650a2831fee,2f1d6bc1-7143-42b7-a5b7-2383d4eddcb9...
Done stopping and starting console proxy vm(s)  with id=9b802cd9-8d97-42dc-9610-2650a2831fee,2f1d6bc1-7143-42b7-a5b7-2383d4eddcb9.

Stopping and starting 0 running routing vm(s) with id=9b802cd9-8d97-42dc-9610-2650a2831fee,2f1d6bc1-7143-42b7-a5b7-2383d4eddcb9...

Fixes apache#6220 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

acs-robot · 2022-07-27T10:58:07Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-07-27T10:59:03Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-07-27T11:07:10Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6574 (SL-JID-2012)

yadvr

needs manual qa, otherwise LGTM

setup/bindir/cloud-sysvmadm.in

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

acs-robot · 2022-08-17T09:48:05Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-08-17T09:49:03Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-08-17T09:54:17Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6574 (SL-JID-2168)

sonarqubecloud · 2022-08-17T10:42:30Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

codecov · 2022-08-17T17:48:14Z

Codecov Report

❗ No coverage uploaded for pull request base (main@4b8af6f). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #6574   +/-   ##
=======================================
  Coverage        ?   11.50%           
  Complexity      ?     7532           
=======================================
  Files           ?     2492           
  Lines           ?   246775           
  Branches        ?    38559           
=======================================
  Hits            ?    28387           
  Misses          ?   214791           
  Partials        ?     3597

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

yadvr · 2022-10-08T06:39:33Z

@shwstppr is this good for review/merge?

DaanHoogland · 2022-12-13T09:02:18Z

@blueorangutan package

blueorangutan · 2022-12-13T09:03:03Z

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

weizhouapache

code lgtm
left 2 minor comments

weizhouapache · 2022-12-13T09:07:31Z

setup/bindir/cloud-sysvmadm.in


 usage() {
-  printf "\nThe tool stopping/starting running system vms and domain routers \n\nUsage: %s: [-d] [-u] [-p] [-m] [-s] [-r] [-a] [-t] [-n] [-z] [-v]\n\n -d - cloud DB server ip address, defaulted to localhost if not specified \n -u - user name to access cloud DB, defaulted to "root" if not specified \n -p - cloud DB user password, defaulted to no password if not specified \n\n -m - the ip address of management server, defaulted to localhost if not specified\n\n -s - stop then start all running SSVMs and Console Proxies \n -r - stop then start all running Virtual Routers\n -a - stop then start all running SSVMs, Console Proxies, and Virtual Routers \n -n - restart all Guest networks \n -t - number of parallel threads used for stopping Domain Routers. Default is 10.\n -l - log file location. Default is cloud.log under current directory.\n -z - do restart only for the instances in the specific zone. If not specified, restart will apply to instances in all zones\n -v - do restart all VPCs in the entire system\n\n" $(basename $0) >&2
+  printf "\nThe tool stopping/starting running system vms and domain routers \n\nUsage: %s: [-d] [-u] [-p] [-m] [-s] [-r] [-a] [-t] [-n] [-z] [-i] [-j] [-v] [-i] [-j]\n\n -d - cloud DB server ip address, defaulted to localhost if not specified \n -u - user name to access cloud DB, defaulted to "root" if not specified \n -p - cloud DB user password, defaulted to no password if not specified \n\n -m - the ip address of management server, defaulted to localhost if not specified\n\n -s - stop then start all running SSVMs and Console Proxies \n -r - stop then start all running Virtual Routers\n -a - stop then start all running SSVMs, Console Proxies, and Virtual Routers \n -n - restart all Guest networks \n -t - number of parallel threads used for stopping Domain Routers. Default is 10.\n -l - log file location. Default is cloud.log under current directory.\n -z - do restart only for the instances in the specific zone. If not specified, restart will apply to instances in all zones\n -v - do restart all VPCs in the entire system\n -i - do restart on instances with specific IDs. Comma-separated instance IDs to be provided. Works ony when restarting SSVMs, CPVMs or VRs\n -j - do restart on instances from the specified database table. If not specified, restart will apply on instances present in cloud.vm_instance database table. Works ony when restarting SSVMs, CPVMs or VRs\n\n" $(basename $0) >&2


duplicated [-i] [-j]

@shwstppr
can you organize this by multiple lines ? it is hard to review.

@weizhouapache refactored

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

setup/bindir/cloud-sysvmadm.in

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

blueorangutan · 2022-12-13T11:28:52Z

Packaging result: ✖️ el7 ✖️ el8 ✖️ debian ✖️ suse15. SL-JID 4881

blueorangutan · 2022-12-13T18:15:11Z

Packaging result: ✖️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 4902

blueorangutan · 2022-12-16T11:07:41Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 4982

DaanHoogland · 2022-12-16T12:50:46Z

@blueorangutan test matrix

blueorangutan · 2022-12-16T12:51:04Z

@DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

shwstppr · 2022-12-16T13:36:53Z

@DaanHoogland I don't think the script, this PR changes, is called by the management server or any agent

blueorangutan · 2022-12-17T00:16:06Z

Trillian test result (tid-5528)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39666 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6574-t5528-xenserver-71.zip
Smoke tests completed. 105 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2022-12-17T01:39:15Z

Trillian test result (tid-5529)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44535 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6574-t5529-kvm-centos7.zip
Smoke tests completed. 104 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_vpc_site2site_vpn_multiple_options	`Failure`	497.08	test_vpc_vpn.py
test_01_vpc_site2site_vpn	`Failure`	395.24	test_vpc_vpn.py

scripts: parametrize systemvm, router restart

ef8eb52

Fixes apache#6220 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

yadvr approved these changes Jul 29, 2022

View reviewed changes

shwstppr mentioned this pull request Jul 29, 2022

Parametrize data source table for virtual routetrs to support migration #6220

Closed

shwstppr marked this pull request as ready for review July 29, 2022 12:52

yadvr added this to the 4.17.1.0 milestone Aug 17, 2022

yadvr requested review from Pearl1594 and weizhouapache August 17, 2022 08:30

weizhouapache reviewed Aug 17, 2022

View reviewed changes

setup/bindir/cloud-sysvmadm.in Show resolved Hide resolved

typo in method name

1340931

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr modified the milestones: 4.17.1.0, 4.18.0.0 Aug 18, 2022

shwstppr changed the base branch from 4.17 to main August 18, 2022 12:21

weizhouapache approved these changes Dec 13, 2022

View reviewed changes

refactor usage

53242c1

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

weizhouapache reviewed Dec 13, 2022

View reviewed changes

setup/bindir/cloud-sysvmadm.in Outdated Show resolved Hide resolved

setup/bindir/cloud-sysvmadm.in Outdated Show resolved Hide resolved

setup/bindir/cloud-sysvmadm.in Outdated Show resolved Hide resolved

shwstppr added 2 commits December 13, 2022 16:42

fix

fddd58d

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

typo

7f67ed2

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

DaanHoogland merged commit 87b25b9 into apache:main Dec 19, 2022

Conversation

shwstppr commented Jul 27, 2022

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

acs-robot commented Jul 27, 2022

Uh oh!

blueorangutan commented Jul 27, 2022

Uh oh!

blueorangutan commented Jul 27, 2022

Uh oh!

yadvr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

acs-robot commented Aug 17, 2022

Uh oh!

blueorangutan commented Aug 17, 2022

Uh oh!

blueorangutan commented Aug 17, 2022

Uh oh!

sonarqubecloud bot commented Aug 17, 2022

Uh oh!

codecov bot commented Aug 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

yadvr commented Oct 8, 2022

Uh oh!

DaanHoogland commented Dec 13, 2022

Uh oh!

blueorangutan commented Dec 13, 2022

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

weizhouapache Dec 13, 2022

Choose a reason for hiding this comment

Uh oh!

weizhouapache Dec 13, 2022

Choose a reason for hiding this comment

Uh oh!

shwstppr Dec 13, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

blueorangutan commented Dec 13, 2022

Uh oh!

blueorangutan commented Dec 13, 2022

Uh oh!

blueorangutan commented Dec 16, 2022

Uh oh!

DaanHoogland commented Dec 16, 2022

Uh oh!

blueorangutan commented Dec 16, 2022

Uh oh!

shwstppr commented Dec 16, 2022

Uh oh!

blueorangutan commented Dec 17, 2022

Uh oh!

blueorangutan commented Dec 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Aug 17, 2022 •

edited

Loading