Console access enhancements by nvazquez · Pull Request #6577 · apache/cloudstack

nvazquez · 2022-07-27T14:03:24Z

Description

This PR creates a new API createConsoleEndpoint to create VM console URL allowing it to connect using other UI implementations. To avoid reply attacks, the console access is enhanced to use a one time token per session

New configuration added:

consoleproxy.extra.security.validation.enabled: Enable/disable extra security validation for console proxy using a token

Documentation PR: apache/cloudstack-documentation#284

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Tested on KVM env

server/src/main/java/com/cloud/consoleproxy/ConsoleAccessManagerImpl.java

acs-robot · 2022-08-01T17:17:40Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-08-01T17:18:03Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-08-01T17:23:57Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6577 (SL-JID-2044)

server/src/main/java/com/cloud/consoleproxy/ConsoleAccessManagerImpl.java

nvazquez · 2022-08-15T03:12:24Z

@blueorangutan package

acs-robot · 2022-08-15T03:12:59Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-08-15T03:13:02Z

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-08-15T03:27:19Z

Packaging result: ✖️ el7 ✖️ el8 ✖️ debian ✖️ suse15. SL-JID 3979

nvazquez · 2022-08-15T03:42:28Z

@blueorangutan package

acs-robot · 2022-08-15T03:42:59Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-08-15T03:43:03Z

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-08-15T04:24:36Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3981

nvazquez · 2022-08-15T04:43:12Z

@blueorangutan test

blueorangutan · 2022-08-15T04:44:02Z

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

codecov · 2022-08-15T06:22:16Z

Codecov Report

Merging #6577 (42e4497) into main (152a274) will increase coverage by 4.54%.
The diff coverage is 4.49%.

@@             Coverage Diff              @@
##               main    #6577      +/-   ##
============================================
+ Coverage      5.87%   10.41%   +4.54%     
- Complexity     3933     6690    +2757     
============================================
  Files          2454     2455       +1     
  Lines        242633   243131     +498     
  Branches      37970    38062      +92     
============================================
+ Hits          14246    25316   +11070     
+ Misses       226811   214649   -12162     
- Partials       1576     3166    +1590

Impacted Files	Coverage Δ
.../main/java/com/cloud/capacity/CapacityManager.java	`100.00% <ø> (+100.00%)`	⬆️
...ud/consoleproxy/AgentBasedConsoleProxyManager.java	`0.00% <0.00%> (ø)`
...ain/java/com/cloud/consoleproxy/AgentHookBase.java	`0.00% <0.00%> (ø)`
...va/com/cloud/consoleproxy/ConsoleProxyManager.java	`0.00% <0.00%> (ø)`
...om/cloud/consoleproxy/ConsoleProxyManagerImpl.java	`6.88% <0.00%> (+6.88%)`	⬆️
...in/java/com/cloud/server/ManagementServerImpl.java	`2.47% <0.00%> (+2.47%)`	⬆️
...ava/com/cloud/servlet/ConsoleProxyClientParam.java	`0.00% <0.00%> (ø)`
...in/java/com/cloud/servlet/ConsoleProxyServlet.java	`5.29% <0.00%> (+5.29%)`	⬆️
...udstack/consoleproxy/ConsoleAccessManagerImpl.java	`5.09% <5.09%> (ø)`
server/src/main/java/com/cloud/api/ApiServlet.java	`39.28% <28.57%> (+39.28%)`	⬆️
... and 487 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

acs-robot · 2022-08-15T12:15:50Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-08-15T12:16:03Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-08-15T12:21:15Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6577 (SL-JID-2145)

yadvr · 2022-08-15T13:07:28Z

@nvazquez can you rebase your branch against upstream main branch?

blueorangutan · 2022-09-02T11:26:03Z

@borisstoyanov a Jenkins job has been kicked to build packages. It will be bundled with
SystemVM template(s). I'll keep you posted as I make progress.

blueorangutan · 2022-09-02T11:30:33Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6577 (SL-JID-2283)

blueorangutan · 2022-09-02T12:01:56Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 4118

borisstoyanov

LGTM

yadvr · 2022-09-07T12:16:51Z

@blueorangutan test

blueorangutan · 2022-09-07T12:17:03Z

@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-09-07T23:07:47Z

Trillian test result (tid-4837)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37727 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6577-t4837-kvm-centos7.zip
Smoke tests completed. 102 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

.../main/java/org/apache/cloudstack/api/command/user/consoleproxy/CreateConsoleEndpointCmd.java

api/src/main/java/org/apache/cloudstack/consoleproxy/ConsoleAccessManager.java

server/src/main/java/com/cloud/server/ManagementServerImpl.java

server/src/main/java/com/cloud/servlet/ConsoleProxyClientParam.java

server/src/main/java/org/apache/cloudstack/consoleproxy/ConsoleAccessManagerImpl.java

yadvr · 2022-09-12T09:26:42Z

LGTM

@nvazquez can you review the outstanding comments and advise if this is ready for merging cc @borisstoyanov @vladimirpetrov

nvazquez · 2022-09-13T03:43:03Z

Thanks @GutoVeronezi, have addressed your comments
@rohityadavcloud yes it is ready for merging

nvazquez · 2022-09-13T03:43:11Z

@blueorangutan package

blueorangutan · 2022-09-13T03:44:02Z

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

acs-robot · 2022-09-13T03:44:29Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-09-13T03:45:03Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-09-13T03:55:38Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6577 (SL-JID-2345)

blueorangutan · 2022-09-13T04:29:16Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 4175

sonarqubecloud · 2022-09-13T04:37:13Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
6 Code Smells

4.3% Coverage
3.3% Duplication

nvazquez · 2022-09-13T10:09:13Z

@blueorangutan test

blueorangutan · 2022-09-13T10:10:03Z

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-09-13T10:30:22Z

Trillian Build Failed (tid-4887)

yadvr · 2022-09-13T10:37:31Z

@blueorangutan test

blueorangutan · 2022-09-13T10:38:02Z

@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-09-13T21:36:02Z

Trillian test result (tid-4888)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38042 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6577-t4888-kvm-centos7.zip
Smoke tests completed. 102 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

nvazquez added component:console-proxy type:new-feature labels Jul 27, 2022

nvazquez added this to the 4.18.0.0 milestone Jul 27, 2022

boring-cyborg bot added component:api component:management-server Python Warning... Python code Ahead! labels Jul 27, 2022

weizhouapache reviewed Jul 27, 2022

View reviewed changes

server/src/main/java/com/cloud/consoleproxy/ConsoleAccessManagerImpl.java Outdated Show resolved Hide resolved

nvazquez changed the title ~~New API: createConsoleURL~~ [WIP] New API: createConsoleURL Jul 28, 2022

boring-cyborg bot added the component:UI label Aug 1, 2022

JoaoJandre reviewed Aug 3, 2022

View reviewed changes

boring-cyborg bot added component:agent component:kvm labels Aug 15, 2022

borisstoyanov approved these changes Sep 5, 2022

View reviewed changes

GutoVeronezi reviewed Sep 9, 2022

View reviewed changes

Address review comments

42e4497

yadvr merged commit b2fbe7b into apache:main Sep 14, 2022

fermosan mentioned this pull request Oct 14, 2022

Console Proxy - No authorization to connect #6828

Closed

GutoVeronezi mentioned this pull request Jan 13, 2023

Handle console session in multiple management servers #7094

Merged

10 tasks

weizhouapache mentioned this pull request Jan 23, 2023

[4.18/main] CPVM does not work after live-patch #7123

Closed

ezntt mentioned this pull request Mar 17, 2023

UI: Add button to copy VM console URL to clipboard #7351

Merged

7 tasks

JoaoJandre mentioned this pull request Nov 28, 2023

Console not working with Primate UI #8113

Closed

Conversation

nvazquez commented Jul 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

Uh oh!

acs-robot commented Aug 1, 2022

Uh oh!

blueorangutan commented Aug 1, 2022

Uh oh!

blueorangutan commented Aug 1, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nvazquez commented Aug 15, 2022

Uh oh!

acs-robot commented Aug 15, 2022

Uh oh!

blueorangutan commented Aug 15, 2022

Uh oh!

blueorangutan commented Aug 15, 2022

Uh oh!

nvazquez commented Aug 15, 2022

Uh oh!

acs-robot commented Aug 15, 2022

Uh oh!

blueorangutan commented Aug 15, 2022

Uh oh!

blueorangutan commented Aug 15, 2022

Uh oh!

nvazquez commented Aug 15, 2022

Uh oh!

blueorangutan commented Aug 15, 2022

Uh oh!

codecov bot commented Aug 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

acs-robot commented Aug 15, 2022

Uh oh!

blueorangutan commented Aug 15, 2022

Uh oh!

blueorangutan commented Aug 15, 2022

Uh oh!

yadvr commented Aug 15, 2022

Uh oh!

blueorangutan commented Sep 2, 2022

Uh oh!

blueorangutan commented Sep 2, 2022

Uh oh!

blueorangutan commented Sep 2, 2022

Uh oh!

borisstoyanov left a comment

Choose a reason for hiding this comment

Uh oh!

yadvr commented Sep 7, 2022

Uh oh!

blueorangutan commented Sep 7, 2022

Uh oh!

blueorangutan commented Sep 7, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nvazquez commented Jul 27, 2022 •

edited

Loading

codecov bot commented Aug 15, 2022 •

edited

Loading