Updated resource counter to include correct size after volume creation/resize and other improvements by sureshanaparti · Pull Request #6587 · apache/cloudstack

sureshanaparti · 2022-07-29T11:44:45Z

Description

This PR updates primary_storage resource counter to include correct size after volume creation/resize and other improvements.

Recalculate resource counters for root domain in the periodic task
Update correct size in the primary_storage resource counter after volume creation/resize
Some code improvements

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

How Has This Been Tested?

Manually tested VM/Volume operations using ScaleIO/PowerFlex pool and checked the primary_storage resource counters for different domains.

Before fix (primarystorageavailable counter is not shown appropriately for unlimited):

(testenv) 🐱 > list domains filter=name,primarystoragetotal,primarystoragelimit,primarystorageavailable
{
  "count": 3,
  "domain": [
    {
      "name": "ROOT",
      "primarystorageavailable": "Unlimited",
      "primarystoragelimit": "Unlimited",
      "primarystoragetotal": -5
    },
    {
      "name": "Domain01",
      "primarystorageavailable": "-1",
      "primarystoragelimit": "-1",
      "primarystoragetotal": 0
    },
    {
      "name": "Domain02",
      "primarystorageavailable": "-1",
      "primarystoragelimit": "-1",
      "primarystoragetotal": 0
    }
  ]
}
(testenv) 🐱 > list domains filter=name,primarystoragetotal,primarystoragelimit,primarystorageavailable
{
  "count": 3,
  "domain": [
    {
      "name": "ROOT",
      "primarystorageavailable": "Unlimited",
      "primarystoragelimit": "Unlimited",
      "primarystoragetotal": 3
    },
    {
      "name": "Domain01",
      "primarystorageavailable": "-9",
      "primarystoragelimit": "-1",
      "primarystoragetotal": 8
    },
    {
      "name": "Domain02",
      "primarystorageavailable": "-1",
      "primarystoragelimit": "-1",
      "primarystoragetotal": 0
    }
  ]
}
(testenv) 🐱 > list domains filter=name,primarystoragetotal,primarystoragelimit,primarystorageavailable
{
  "count": 3,
  "domain": [
    {
      "name": "ROOT",
      "primarystorageavailable": "Unlimited",
      "primarystoragelimit": "Unlimited",
      "primarystoragetotal": 6
    },
    {
      "name": "Domain01",
      "primarystorageavailable": "-25",
      "primarystoragelimit": "-1",
      "primarystoragetotal": 24
    },
    {
      "name": "Domain02",
      "primarystorageavailable": "-1",
      "primarystoragelimit": "-1",
      "primarystoragetotal": 0
    }
  ]
}

After fix =>

(testenv) 🐱 > list domains filter=name,primarystoragetotal,primarystoragelimit,primarystorageavailable
{
  "count": 3,
  "domain": [
    {
      "name": "ROOT",
      "primarystorageavailable": "Unlimited",
      "primarystoragelimit": "Unlimited",
      "primarystoragetotal": 88
    },
    {
      "name": "Domain01",
      "primarystorageavailable": "Unlimited",
      "primarystoragelimit": "Unlimited",
      "primarystoragetotal": 40
    },
    {
      "name": "Domain02",
      "primarystorageavailable": "Unlimited",
      "primarystoragelimit": "Unlimited",
      "primarystoragetotal": 24
    }
  ]
}

…n/resize and other improvements - Recalculate resource counters for root domain in the periodic task - Update correct size in the primary_storage resource counter after volume creation/resize - Some code improvements

sureshanaparti · 2022-07-29T11:49:39Z

@blueorangutan package

blueorangutan · 2022-07-29T11:50:03Z

@sureshanaparti a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-07-29T12:30:53Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3856

sureshanaparti · 2022-07-29T12:31:27Z

@blueorangutan test

blueorangutan · 2022-07-29T12:32:03Z

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

server/src/main/java/com/cloud/resourcelimit/ResourceLimitManagerImpl.java

engine/storage/volume/src/main/java/org/apache/cloudstack/storage/volume/VolumeObject.java

acs-robot · 2022-08-03T15:21:58Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-08-03T15:23:03Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-08-03T15:28:30Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6587 (SL-JID-2073)

sonarqubecloud · 2022-08-03T16:28:17Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

15.5% Coverage
0.0% Duplication

JoaoJandre

CLGTM

DaanHoogland · 2022-08-04T08:37:29Z

@blueorangutan package

blueorangutan · 2022-08-04T08:38:03Z

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-08-04T09:19:20Z

Packaging result: ✖️ el7 ✖️ el8 ✖️ debian ✔️ suse15. SL-JID 3902

blueorangutan · 2022-08-04T13:43:21Z

Packaging result: ✖️ el7 ✔️ el8 ✖️ debian ✖️ suse15. SL-JID 3907

blueorangutan · 2022-08-05T10:31:54Z

Packaging result: ✖️ el7 ✔️ el8 ✖️ debian ✖️ suse15. SL-JID 3913

blueorangutan · 2022-08-05T11:35:50Z

Packaging result: ✖️ el7 ✖️ el8 ✖️ debian ✖️ suse15. SL-JID 3917

sureshanaparti · 2022-08-07T17:25:17Z

@blueorangutan package

blueorangutan · 2022-08-07T17:26:03Z

@sureshanaparti a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-08-08T04:20:11Z

Packaging result: ✖️ el7 ✔️ el8 ✖️ debian ✖️ suse15. SL-JID 3926

borisstoyanov · 2022-08-09T06:45:49Z

@blueorangutan package

blueorangutan · 2022-08-09T06:46:02Z

@borisstoyanov a Jenkins job has been kicked to build packages. It will be bundled with
SystemVM template(s). I'll keep you posted as I make progress.

blueorangutan · 2022-08-09T07:28:07Z

Packaging result: ✖️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3944

blueorangutan · 2022-08-09T08:15:27Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3945

borisstoyanov · 2022-08-11T06:48:07Z

@blueorangutan test

blueorangutan · 2022-08-11T06:49:03Z

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-08-11T18:14:20Z

Trillian test result (tid-4672)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39739 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6587-t4672-kvm-centos7.zip
Smoke tests completed. 100 look OK, 1 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_08_upgrade_kubernetes_ha_cluster	`Failure`	621.02	test_kubernetes_clusters.py

borisstoyanov

LGTM

yadvr · 2022-08-16T09:57:43Z

cc @harikrishna-patnala @shwstppr @DaanHoogland do we need this in 4.17 branch?

…n/resize and other improvements (apache#6587) * Updated resource counter to include correct size after volume creation/resize and other improvements - Recalculate resource counters for root domain in the periodic task - Update correct size in the primary_storage resource counter after volume creation/resize - Some code improvements * review and sonarcloud issues Co-authored-by: Suresh Kumar Anaparti <suresh.anaparti@shapeblue.com> Co-authored-by: Daan Hoogland <daan@onecht.net>

boring-cyborg bot added component:api component:storage labels Jul 29, 2022

apache deleted a comment from blueorangutan Jul 29, 2022

GutoVeronezi reviewed Aug 3, 2022

View reviewed changes

server/src/main/java/com/cloud/resourcelimit/ResourceLimitManagerImpl.java Outdated Show resolved Hide resolved

engine/storage/volume/src/main/java/org/apache/cloudstack/storage/volume/VolumeObject.java Outdated Show resolved Hide resolved

DaanHoogland reviewed Aug 3, 2022

View reviewed changes

engine/storage/volume/src/main/java/org/apache/cloudstack/storage/volume/VolumeObject.java Outdated Show resolved Hide resolved

DaanHoogland reviewed Aug 3, 2022

View reviewed changes

engine/storage/volume/src/main/java/org/apache/cloudstack/storage/volume/VolumeObject.java Outdated Show resolved Hide resolved

review and sonarcloud issues

8fde797

JoaoJandre approved these changes Aug 3, 2022

View reviewed changes

DaanHoogland marked this pull request as draft August 4, 2022 08:37

borisstoyanov approved these changes Aug 16, 2022

View reviewed changes

DaanHoogland marked this pull request as ready for review August 16, 2022 08:40

DaanHoogland merged commit 75da982 into apache:main Aug 16, 2022

yadvr added this to the 4.18.0.0 milestone Aug 16, 2022

Conversation

sureshanaparti commented Jul 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

How Has This Been Tested?

Uh oh!

sureshanaparti commented Jul 29, 2022

Uh oh!

blueorangutan commented Jul 29, 2022

Uh oh!

blueorangutan commented Jul 29, 2022

Uh oh!

sureshanaparti commented Jul 29, 2022

Uh oh!

blueorangutan commented Jul 29, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

acs-robot commented Aug 3, 2022

Uh oh!

blueorangutan commented Aug 3, 2022

Uh oh!

blueorangutan commented Aug 3, 2022

Uh oh!

sonarqubecloud bot commented Aug 3, 2022

Uh oh!

JoaoJandre left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Aug 4, 2022

Uh oh!

blueorangutan commented Aug 4, 2022

Uh oh!

blueorangutan commented Aug 4, 2022

Uh oh!

blueorangutan commented Aug 4, 2022

Uh oh!

blueorangutan commented Aug 5, 2022

Uh oh!

blueorangutan commented Aug 5, 2022

Uh oh!

sureshanaparti commented Aug 7, 2022

Uh oh!

blueorangutan commented Aug 7, 2022

Uh oh!

blueorangutan commented Aug 8, 2022

Uh oh!

borisstoyanov commented Aug 9, 2022

Uh oh!

blueorangutan commented Aug 9, 2022

Uh oh!

blueorangutan commented Aug 9, 2022

Uh oh!

blueorangutan commented Aug 9, 2022

Uh oh!

borisstoyanov commented Aug 11, 2022

Uh oh!

blueorangutan commented Aug 11, 2022

Uh oh!

blueorangutan commented Aug 11, 2022

Uh oh!

borisstoyanov left a comment

Choose a reason for hiding this comment

Uh oh!

yadvr commented Aug 16, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

sureshanaparti commented Jul 29, 2022 •

edited

Loading